[Bug libc/10847] New: getutmpx is missing in libc.so.6

[Bug libc/10847] New: getutmpx is missing in libc.so.6

[aurelien at aurel32 dot net]

On 32-bit S390 systems, getutmpx@@GLIBC_2.9 is missing in libc.so.6, only
getutmpx@@GLIBC_2.1.1 is present. This is due to the compat code:

getutmpx is defined in sysdeps/unix/sysv/linux/s390/s390-32/getutmp.c:
#define getutmpx __getutmpx
#include "sysdeps/gnu/getutmp.c"

and undefined in sysdeps/gnu/getutmp.c:
/* This is an ugly hack but we must not see the getutmpx declaration.  */
#define getutmpx XXXgetutmpx
#include <utmpx.h>
#undef getutmpx

The attached patch fixes the problem by not including sysdeps/gnu/getutmp.c, but
copying part of the code directly into
sysdeps/unix/sysv/linux/s390/s390-32/getutmp.c

-- 
           Summary: getutmpx is missing in libc.so.6
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper at redhat dot com
        ReportedBy: aurelien at aurel32 dot net
                CC: glibc-bugs at sources dot redhat dot com
 GCC build triplet: s390-linux-gnu
  GCC host triplet: s390-linux-gnu
GCC target triplet: s390-linux-gnu


http://sourceware.org/bugzilla/show_bug.cgi?id=10847

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/10847] getutmpx is missing in libc.so.6

[aurelien at aurel32 dot net]

------- Additional Comments From aurelien at aurel32 dot net  2009-10-26 16:06 -------
Created an attachment (id=4320)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4320&action=view)
Patch to fix the problem


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10847

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/10847] getutmpx is missing in libc.so.6

[jakub at redhat dot com]

------- Additional Comments From jakub at redhat dot com  2009-10-26 16:17 -------
What are the advantages of duplicating the code?
IMHO just add strong_alias (__getutmp, __getutmpx); after the include, and
possibly s/weak_alias/strong_alias/ also in the s390-32/getutmp.c.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10847

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/10847] getutmpx is missing in libc.so.6

[aurelien at aurel32 dot net]

------- Additional Comments From aurelien at aurel32 dot net  2009-10-26 16:21 -------
I didn't though about this possibility, I'll try this option and send a new patch

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10847

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/10847] getutmpx is missing in libc.so.6

[aurelien at aurel32 dot net]

------- Additional Comments From aurelien at aurel32 dot net  2009-10-26 17:26 -------
Created an attachment (id=4321)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4321&action=view)
New patch

Please find a new patch attached.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #4320 is|0                           |1
           obsolete|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=10847

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/10847] getutmpx is missing in libc.so.6

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2009-10-29 15:33 -------
I fixed this in git but not with the patch attached here.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=10847

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/10847] getutmpx is missing in libc.so.6

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=10847

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.