public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/11039] New: getopt mishandles optstring of "+:"
@ 2009-12-01 16:28 ebb9 at byu dot net
2009-12-01 16:32 ` [Bug libc/11039] " ebb9 at byu dot net
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: ebb9 at byu dot net @ 2009-12-01 16:28 UTC (permalink / raw)
To: glibc-bugs
According to the getopt man pages, for example:
http://www.kernel.org/doc/man-pages/online/pages/man3/getopt.3.html
If the first character (following any optional '+' or '-' described above) of
optstring is a colon (':'), then getopt() returns ':' instead of '?' to indicate
a missing option argument.
However, the code in getopt.c does not consistently follow this rule.
$ cat foo.c
#include <unistd.h>
#include <stdio.h>
int
main (int argc, char **argv)
{
int c = getopt (argc, argv, "+:a:b");
if (c == -1)
puts ("got -1");
else
printf ("got %c\n", c);
c = getopt (argc, argv, "+:a:b");
if (c == -1)
puts ("got -1");
else
printf ("got %c\n", c);
return 0;
}
$ ./foo -a
./foo2: option requires an argument -- a
got :
got -1
$ ./foo -b -a
got b
./foo2: option requires an argument -- a
got ?
Expected behavior - stderr should be silent, and the -a without argument should
return ':', not '?'.
Workaround: code can set opterr=0 before the first getopt{,_long} call (to
silence the spurious warning if argv[1] is missing an argument), then leave off
the leading '-' or '+' of opstring for all subsequent calls for a given
argc/argv parse (to silence the warning and return ':' instead of '?' if any
subsequent argv is missing an argument).
--
Summary: getopt mishandles optstring of "+:"
Product: glibc
Version: 2.11
Status: NEW
Severity: normal
Priority: P2
Component: libc
AssignedTo: drepper at redhat dot com
ReportedBy: ebb9 at byu dot net
CC: glibc-bugs at sources dot redhat dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=11039
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug libc/11039] getopt mishandles optstring of "+:"
2009-12-01 16:28 [Bug libc/11039] New: getopt mishandles optstring of "+:" ebb9 at byu dot net
@ 2009-12-01 16:32 ` ebb9 at byu dot net
2009-12-02 22:17 ` ebb9 at byu dot net
2010-04-08 0:57 ` drepper at redhat dot com
2 siblings, 0 replies; 5+ messages in thread
From: ebb9 at byu dot net @ 2009-12-01 16:32 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From ebb9 at byu dot net 2009-12-01 16:32 -------
Created an attachment (id=4435)
--> (http://sourceware.org/bugzilla/attachment.cgi?id=4435&action=view)
patch
2009-12-01 Eric Blake <ebb9@byu.net>
* posix/getopt.c (_getopt_internal_r): Skip optional - or + before
checking lead byte of optstring for :.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=11039
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug libc/11039] getopt mishandles optstring of "+:"
2009-12-01 16:28 [Bug libc/11039] New: getopt mishandles optstring of "+:" ebb9 at byu dot net
2009-12-01 16:32 ` [Bug libc/11039] " ebb9 at byu dot net
@ 2009-12-02 22:17 ` ebb9 at byu dot net
2010-04-08 0:57 ` drepper at redhat dot com
2 siblings, 0 replies; 5+ messages in thread
From: ebb9 at byu dot net @ 2009-12-02 22:17 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From ebb9 at byu dot net 2009-12-02 22:17 -------
Another related problem, which is also fixed by the previously posted patch:
$ cat foo.c
#include <unistd.h>
#include <stdio.h>
int
main (int argc, char **argv)
{
int i, c;
for (i = 0; i <= 1; i++)
{
optind = i;
c = getopt (argc, argv, "+a");
if (c == -1)
printf ("got -1, optind %d\n", optind);
else
printf ("got %c, optind %d\n", c, optind);
}
return 0;
}
$ ./foo -+
foo: invalid option -- '+'
got ?, optind 2
got +, optind 2
Expected behavior is for the error message to occur twice on stderr, with both
passes returning '?'.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=11039
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug libc/11039] getopt mishandles optstring of "+:"
2009-12-01 16:28 [Bug libc/11039] New: getopt mishandles optstring of "+:" ebb9 at byu dot net
2009-12-01 16:32 ` [Bug libc/11039] " ebb9 at byu dot net
2009-12-02 22:17 ` ebb9 at byu dot net
@ 2010-04-08 0:57 ` drepper at redhat dot com
2 siblings, 0 replies; 5+ messages in thread
From: drepper at redhat dot com @ 2010-04-08 0:57 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From drepper at redhat dot com 2010-04-08 00:56 -------
Fixed in git.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://sourceware.org/bugzilla/show_bug.cgi?id=11039
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <bug-11039-131@http.sourceware.org/bugzilla/>]
end of thread, other threads:[~2014-06-30 20:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-12-01 16:28 [Bug libc/11039] New: getopt mishandles optstring of "+:" ebb9 at byu dot net
2009-12-01 16:32 ` [Bug libc/11039] " ebb9 at byu dot net
2009-12-02 22:17 ` ebb9 at byu dot net
2010-04-08 0:57 ` drepper at redhat dot com
[not found] <bug-11039-131@http.sourceware.org/bugzilla/>
2014-06-30 20:36 ` fweimer at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).