[Bug libc/11099] New: INT_FIELD_MAYBE_NULL changed behaviour on x86_64

[Bug libc/11099] New: INT_FIELD_MAYBE_NULL changed behaviour on x86_64

[pterjan at mandriva dot com]

We had password aging bugs on Mandriva and I found that when a field of
/etc/shadow contains -1, it gets 32 bits value of -1 on x86_64 even if the field
is long in the struct.

According to the doc it should indeed be empty to disable instead of containing
-1, but well the field is signed and nothing prevents from having a negative value

It used to work and the behavior change broke tests like spw->sp_* != -1 in pam
modules

The change was introduced by
http://repo.or.cz/w/glibc.git/commitdiff/1e545d0185072ac0d4646223d509c3692cbe550a with
a commit message unrelated to this part of the commit

-- 
           Summary: INT_FIELD_MAYBE_NULL changed behaviour on x86_64
           Product: glibc
           Version: 2.11
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper at redhat dot com
        ReportedBy: pterjan at mandriva dot com
                CC: glibc-bugs at sources dot redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=11099

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/11099] INT_FIELD_MAYBE_NULL changed behaviour on x86_64

[schwab at linux-m68k dot org]

------- Additional Comments From schwab at linux-m68k dot org  2009-12-17 09:20 -------
The CVS->git conversion is broken, use the CVS log.

	[BZ #9706]
	* nss/nss_files/files-parse.c (strtou32): New function.
	(INT_FIELD): Use strotu32 instead of strtoul to unify behavior
	across 32-bit and 64-bit platforms.
	(INT_FIELD_MAYBE_NULL): Likewise.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11099

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/11099] INT_FIELD_MAYBE_NULL changed behaviour on x86_64

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2010-04-05 04:33 -------
The behavior is as expected.  Otherwise 32 and 64 platforms behave differently.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID


http://sourceware.org/bugzilla/show_bug.cgi?id=11099

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/11099] INT_FIELD_MAYBE_NULL changed behaviour on x86_64

[pterjan at mandriva dot com]

------- Additional Comments From pterjan at mandriva dot com  2010-04-05 15:13 -------
Well handling an unsigned field as if it was signed _make it_ behave differently
on 32 and 64 bits platforms.

Yes this changes makes sense for unsigned field like ones in passwd, but not for
signed fields like ones in spwd.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|INVALID                     |


http://sourceware.org/bugzilla/show_bug.cgi?id=11099

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/11099] INT_FIELD_MAYBE_NULL changed behaviour on x86_64

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=11099

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/11099] INT_FIELD_MAYBE_NULL changed behaviour on x86_64

[drepper.fsp at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=11099

Ulrich Drepper <drepper.fsp at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Ulrich Drepper <drepper.fsp at gmail dot com> 2011-05-30 02:28:24 UTC ---
I've added a patch.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.