public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "scarybeasts at gmail dot com" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sources.redhat.com Subject: [Bug libc/11883] New: fnmatch() alloca() abuse, with security consequence Date: Thu, 05 Aug 2010 05:05:00 -0000 [thread overview] Message-ID: <20100805050439.11883.scarybeasts@gmail.com> (raw) Demo: #include <err.h> #include <fnmatch.h> #include <locale.h> #include <stdlib.h> #include <string.h> int main(int argc, const char* argv[]) { size_t num_as; char* p; setlocale(LC_ALL, "en_US.UTF8"); if (argc < 2) { errx(1, "Missing argument."); } num_as = atoi(argv[1]); if (num_as < 5) { errx(1, "Need 5."); } p = malloc(num_as); if (!p) { errx(1, "malloc() failed."); } memset(p, 'A', num_as); p[num_as - 1] = '\0'; p[0] = 'f'; p[1] = 'o'; p[2] = 'o'; p[3] = '.'; fnmatch("*.anim[1-9j]", p, 0); return 0; } ./a.out 3000000 Segmentation fault (If your default max stack size is greater than the default 8MB then you may need a larger number) I chatted to some people and they suggested that there's probably a missing __libc_use_alloca() somewhere. This was the source of a nasty Chromium bug which was worked around for now. [Random aside: I can't seem to find the default value for __libc_alloca_cutoff but if it is > PAGE_SIZE then that in of itself would cause serious issues since most people don't compile glibc with -fstack-check, combined with the fact that pthread stacks by default are separated with a single guard page] -- Summary: fnmatch() alloca() abuse, with security consequence Product: glibc Version: 2.9 Status: NEW Severity: normal Priority: P2 Component: libc AssignedTo: drepper at redhat dot com ReportedBy: scarybeasts at gmail dot com CC: glibc-bugs at sources dot redhat dot com http://sourceware.org/bugzilla/show_bug.cgi?id=11883 ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
next reply other threads:[~2010-08-05 5:05 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-08-05 5:05 scarybeasts at gmail dot com [this message] 2010-08-10 4:27 ` [Bug libc/11883] " drepper at redhat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100805050439.11883.scarybeasts@gmail.com \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sources.redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).