[Bug libc/11903] New: undefined variable in IPTOS_CLASS macro in sysdeps/generic/netinet/ip.h

[Bug libc/11903] New: undefined variable in IPTOS_CLASS macro in sysdeps/generic/netinet/ip.h

[bikovevg at iitp dot ru]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]

Commit dca5d51ebfe240eac1cd030e8c902a25b7a363a5 [1] with commit message
  "Define IPTOS_CLASS_* macros according to RFC 2474."
introduced new IPTOS_CLASS macro.

This macro contains an undefined variable (looks like just a typo).
The macro is
  #define        IPTOS_CLASS(class)              ((tos) & IPTOS_CLASS_MASK)
Note the "class" vs "tos" difference.

This leads to compilation errors due to a line like
  int precedence = IPTOS_PREC(olsr_cnf->tos);
turns into
  int precedence = ((tos) & 0xe0);
and
  error: ‘tos’ undeclared (first use in this function)

[1] 
http://repo.or.cz/w/glibc.git/blobdiff/ace4e23f8c495927d3f24554b41560858ee50d4f.
.dca5d51ebfe240eac1cd030e8c902a25b7a363a5:/sysdeps/generic/netinet/ip.h

-- 
           Summary: undefined variable in IPTOS_CLASS macro in
                    sysdeps/generic/netinet/ip.h
           Product: glibc
           Version: 2.13
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper at redhat dot com
        ReportedBy: bikovevg at iitp dot ru
                CC: glibc-bugs at sources dot redhat dot com
 GCC build triplet: x86_64-redhat-linux
  GCC host triplet: x86_64-redhat-linux
GCC target triplet: x86_64-redhat-linux


http://sourceware.org/bugzilla/show_bug.cgi?id=11903

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/11903] undefined variable in IPTOS_CLASS macro in sysdeps/generic/netinet/ip.h

[bikovevg at iitp dot ru]

------- Additional Comments From bikovevg at iitp dot ru  2010-08-11 08:58 -------
Created an attachment (id=4925)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4925&action=view)
proposed fix


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11903

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/11903] undefined variable in IPTOS_CLASS macro in sysdeps/generic/netinet/ip.h

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2010-08-11 14:44 -------
Fixed in git.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
            Summary|undefined variable in       |undefined variable in
                   |IPTOS_CLASS macro in        |IPTOS_CLASS macro in
                   |sysdeps/generic/netinet/ip.h|sysdeps/generic/netinet/ip.h


http://sourceware.org/bugzilla/show_bug.cgi?id=11903

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.