[Bug libc/10696] tzset_internal doesn't handle changes of timezone file

[Bug libc/10696] tzset_internal doesn't handle changes of timezone file

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=10696

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/10696] New: tzset_internal doesn't handle changes of timezone file

[cfriesen at nortel dot com]

If the TZ environment variable is changed while a program is running, the next
call to tzset_internal will result in picking up the modified timzeone.

However, if the contents of the timezone file are updated (due to a package
upgrade, for instance) or if it's a symlink and it is changed to point to a
different file while a program is running, the tzset_internal function will not
pick up the modifications because the filename is still the same.

I propose modifying this function to also stat() and lstat() the timezone file
and compare the mtime values against values stored along with the filename.  If
either of the timestamps doesn't match the stored value, the timezone file is
re-read.

-- 
           Summary: tzset_internal doesn't handle changes of timezone file
           Product: glibc
           Version: 2.10
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper at redhat dot com
        ReportedBy: cfriesen at nortel dot com
                CC: glibc-bugs at sources dot redhat dot com
 GCC build triplet: n/a
  GCC host triplet: n/a
GCC target triplet: n/a


http://sourceware.org/bugzilla/show_bug.cgi?id=10696

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/10696] tzset_internal doesn't handle changes of timezone file

[cfriesen at nortel dot com]

------- Additional Comments From cfriesen at nortel dot com  2009-09-25 17:18 -------
Created an attachment (id=4231)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4231&action=view)
proposed patch

I propose a patch something along these lines.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10696

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/10696] tzset_internal doesn't handle changes of timezone file

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2009-09-26 19:00 -------
No, this is deliberately like this.  The code is already slow enough.  I'm not
going to add more code to slow things down for a case that never should happen
in the first case.  Restart apps if you need to handle this.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX


http://sourceware.org/bugzilla/show_bug.cgi?id=10696

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.