[Bug libc/11432] getsysstat.c returns erroneous results

[Bug libc/11432] getsysstat.c returns erroneous results

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=11432

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/11432] getsysstat.c returns erroneous results

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2010-04-04 02:21 -------
I've checked in the change.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=11432

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/11432] getsysstat.c returns erroneous results

[rsa at us dot ibm dot com]

------- Additional Comments From rsa at us dot ibm dot com  2010-03-25 16:09 -------
Created an attachment (id=4681)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4681&action=view)
patch to remove erroneous else block from next_line() function.

This patch removes the erroneous else block.  It has been shown in testing to
eliminate the error and the test returns the correct number of CPUs.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11432

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/11432] getsysstat.c returns erroneous results

[rsa at us dot ibm dot com]

------- Additional Comments From rsa at us dot ibm dot com  2010-03-25 16:04 -------
Created an attachment (id=4680)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4680&action=view)
example /proc/stat file which shows the error

The following test case:

#include<stdio.h>
#include<sys/sysinfo.h>
int main()
{
int lcpus=get_nprocs();
printf("logical cpus = %d\n",lcpus);
return 0;
}

Can be run against the attached /proc/stat file which is known to reproduce the

problem:

This stat file can be used with the testcase by bind mounting it over
/proc/stat:
cp stat /dev/shm/stat
mount --bind /dev/shm/stat /proc/stat

When run this should show:

logical cpus = 1024

since cpu1024 is high cpu number.  But it shows something like (which may vary
based on the size of the 'buffer' in the next_line algorithm):

logical cpus = 137

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11432

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.