[Bug linuxthreads/12300] New: [PATCH] RTLD_SINGLE_THREAD_P used unconditionally but only available on ports/NPTL

[Bug linuxthreads/12300] New: [PATCH] RTLD_SINGLE_THREAD_P used unconditionally but only available on ports/NPTL

[rmh at gnu dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=12300

           Summary: [PATCH] RTLD_SINGLE_THREAD_P used unconditionally but
                    only available on ports/NPTL
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: linuxthreads
        AssignedTo: drow@false.org
        ReportedBy: rmh@gnu.org


Created attachment 5149
  --> http://sourceware.org/bugzilla/attachment.cgi?id=5149
patch

RTLD_SINGLE_THREAD_P is used unconditionally in elf/dl-runtime.c.  However on
MIPS platforms it is only defined by NPTL subdir in ports:

sysdeps/unix/sysv/linux/mips/nptl/sysdep-cancel.h:# define RTLD_SINGLE_THREAD_P
\

This patch adds RTLD_SINGLE_THREAD_P for linuxthreads/mips as well.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug linuxthreads/12300] [PATCH] RTLD_SINGLE_THREAD_P used unconditionally but only available on ports/NPTL

[joseph at codesourcery dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12300

--- Comment #1 from joseph at codesourcery dot com <joseph at codesourcery dot com> 2010-12-08 17:05:57 UTC ---
Linuxthreads has been dead for Linux targets at least since glibc 2.5.  We 
really ought to remove those directories

sysdeps/unix/sysv/linux/arm/eabi/linuxthreads
sysdeps/unix/sysv/linux/arm/linuxthreads
sysdeps/unix/sysv/linux/hppa/linuxthreads

in ports to make it clear there's nothing useful there.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug linuxthreads/12300] [PATCH] RTLD_SINGLE_THREAD_P used unconditionally but only available on ports/NPTL

[rmh at gnu dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=12300

--- Comment #2 from Robert Millan <rmh at gnu dot org> 2010-12-08 17:12:46 UTC ---
(In reply to comment #1)
> Linuxthreads has been dead for Linux targets at least since glibc 2.5.  We 
> really ought to remove those directories
> 
> sysdeps/unix/sysv/linux/arm/eabi/linuxthreads
> sysdeps/unix/sysv/linux/arm/linuxthreads
> sysdeps/unix/sysv/linux/hppa/linuxthreads
> 
> in ports to make it clear there's nothing useful there.

Hi Joseph,

Despite its name, linuxthreads is quite portable and (despite its limitations)
is commonly used on non-Linux targets such as kFreeBSD.

I've been unable to find a repository that hosts it.  Has it been completely
removed from sourceware.org?  This seems unfortunate.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug linuxthreads/12300] [PATCH] RTLD_SINGLE_THREAD_P used unconditionally but only available on ports/NPTL

[joseph at codesourcery dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12300

--- Comment #3 from joseph at codesourcery dot com <joseph at codesourcery dot com> 2010-12-08 19:44:31 UTC ---
On Wed, 8 Dec 2010, rmh at gnu dot org wrote:

> http://sourceware.org/bugzilla/show_bug.cgi?id=12300
> 
> --- Comment #2 from Robert Millan <rmh at gnu dot org> 2010-12-08 17:12:46 UTC ---
> (In reply to comment #1)
> > Linuxthreads has been dead for Linux targets at least since glibc 2.5.  We 
> > really ought to remove those directories
> > 
> > sysdeps/unix/sysv/linux/arm/eabi/linuxthreads
> > sysdeps/unix/sysv/linux/arm/linuxthreads
> > sysdeps/unix/sysv/linux/hppa/linuxthreads
> > 
> > in ports to make it clear there's nothing useful there.
> 
> Hi Joseph,
> 
> Despite its name, linuxthreads is quite portable and (despite its limitations)
> is commonly used on non-Linux targets such as kFreeBSD.

The directories I suggested removing were the sysdeps/unix/sysv/linux 
ones, not the other linuxthreads directories in ports that are nominally 
applicable to non-Linux targets.  Your patch was also for a 
sysdeps/unix/sysv/linux directory.

I don't think ports should be a dumping place for dead code someone thinks 
might conceivably be useful one day; we have version control for that.  In 
my view we should remove the various dead and unmaintained code from ports 
and just leave the ports that have some chance of being useful in more or 
less their present state.

I would strongly advise those caring about the other targets to develop 
proper POSIX threads implementations for them that use whatever interfaces 
are most appropriate for each kernel (while making sure that all the 
headers included in generic glibc code present the same interface as the 
NPTL versions do, to avoid problems with generic code only working with 
NPTL) rather than relying on long-unmaintained code that does not work 
well with current libc.  You might be able to use parts of the 
Linuxthreads code or the NPTL code in such implementations; I don't know.

> I've been unable to find a repository that hosts it.  Has it been completely
> removed from sourceware.org?  This seems unfortunate.

The CVS repository (:pserver:anoncvs@sources.redhat.com:/cvs/glibc, module 
linuxthreads) still appears to exist.  It's quite possible that write 
access was blocked when the rest of the repository was converted to git, 
and linuxthreads has not been converted to git and has no maintainers.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug linuxthreads/12300] [PATCH] RTLD_SINGLE_THREAD_P used unconditionally but only available on ports/NPTL

[rmh at gnu dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=12300

--- Comment #4 from Robert Millan <rmh at gnu dot org> 2010-12-08 19:59:07 UTC ---
(In reply to comment #3)
> The directories I suggested removing were the sysdeps/unix/sysv/linux 
> ones, not the other linuxthreads directories in ports that are nominally 
> applicable to non-Linux targets.  Your patch was also for a 
> sysdeps/unix/sysv/linux directory.

Note that as syscall ABI on kFreeBSD is the same as on Linux, sysdep-cancel.h
can be implemented by #including the Linux version (this is why I'm patching a
sysdeps/unix/sysv/linux directory).

> I don't think ports should be a dumping place for dead code someone thinks 
> might conceivably be useful one day;

The missing definition is needed on mipsel-kfreebsd-gnu. Sorry for not making
this clear the first time.

> I would strongly advise those caring about the other targets to develop 
> proper POSIX threads implementations for them that use whatever interfaces 
> are most appropriate for each kernel (while making sure that all the 
> headers included in generic glibc code present the same interface as the 
> NPTL versions do, to avoid problems with generic code only working with 
> NPTL) rather than relying on long-unmaintained code that does not work 
> well with current libc.  You might be able to use parts of the 
> Linuxthreads code or the NPTL code in such implementations; I don't know.

Yeah, I know. Unfortunately manpower doesn't allow this for now (help is
welcome).

> The CVS repository (:pserver:anoncvs@sources.redhat.com:/cvs/glibc, module 
> linuxthreads) still appears to exist.

Thanks for the pointer.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug linuxthreads/12300] [PATCH] RTLD_SINGLE_THREAD_P used unconditionally but only available on ports/NPTL

[joseph at codesourcery dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12300

--- Comment #5 from joseph at codesourcery dot com <joseph at codesourcery dot com> 2010-12-08 20:12:40 UTC ---
On Wed, 8 Dec 2010, rmh at gnu dot org wrote:

> http://sourceware.org/bugzilla/show_bug.cgi?id=12300
> 
> --- Comment #4 from Robert Millan <rmh at gnu dot org> 2010-12-08 19:59:07 UTC ---
> (In reply to comment #3)
> > The directories I suggested removing were the sysdeps/unix/sysv/linux 
> > ones, not the other linuxthreads directories in ports that are nominally 
> > applicable to non-Linux targets.  Your patch was also for a 
> > sysdeps/unix/sysv/linux directory.
> 
> Note that as syscall ABI on kFreeBSD is the same as on Linux, sysdep-cancel.h
> can be implemented by #including the Linux version (this is why I'm patching a
> sysdeps/unix/sysv/linux directory).

If a header is useful for kFreeBSD but no longer of use for Linux, I'd 
advise moving it to a kFreeBSD directory as part of your port.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug linuxthreads/12300] [PATCH] RTLD_SINGLE_THREAD_P used unconditionally but only available on ports/NPTL

[jsm28 at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=12300

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |SUSPENDED
         AssignedTo|drow at false dot org       |unassigned at sourceware
                   |                            |dot org

--- Comment #6 from Joseph Myers <jsm28 at gcc dot gnu.org> 2012-02-16 14:26:30 UTC ---
Suspending, since Linuxthreads is unmaintained and has no current repository.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug linuxthreads/12300] [PATCH] RTLD_SINGLE_THREAD_P used unconditionally but only available on ports/NPTL

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=12300

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|SUSPENDED                   |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #7 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Closing, on the basis that it doesn't make sense to keep bug reports open for
things not part of the current glibc repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug linuxthreads/12300] [PATCH] RTLD_SINGLE_THREAD_P used unconditionally but only available on ports/NPTL

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=12300

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.