public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "eblake at redhat dot com" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sources.redhat.com Subject: [Bug libc/12685] New: fopen doesn't last byte of valid modes Date: Wed, 20 Apr 2011 00:46:00 -0000 [thread overview] Message-ID: <bug-12685-131@http.sourceware.org/bugzilla/> (raw) http://sourceware.org/bugzilla/show_bug.cgi?id=12685 Summary: fopen doesn't last byte of valid modes Product: glibc Version: 2.13 Status: NEW Severity: normal Priority: P2 Component: libc AssignedTo: drepper.fsp@gmail.com ReportedBy: eblake@redhat.com $ cat foo.c #include <stdio.h> #include <fcntl.h> #include <stdlib.h> int main (void) { FILE *f = fopen ("/dev/null", "rb+cmxe"); if (!f) exit (1); int fd = fileno (f); if (fd < 0) exit (2); int mode = fcntl (fd, F_GETFD); if (mode < 0) exit (3); return !(mode & FD_CLOEXEC); } $ ./foo; echo $? 1 Oops - an off-by-one error in fileops.c ended up ignoring 'e'. The same goes for any other valid byte that doesn't appear until mode[6]. diff --git i/libio/fileops.c w/libio/fileops.c index 4698953..ee6ce13 100644 --- i/libio/fileops.c +++ w/libio/fileops.c @@ -1,4 +1,4 @@ -/* Copyright (C) 1993, 1995, 1997-2005, 2006, 2007, 2008, 2009 +/* Copyright (C) 1993, 1995, 1997-2005, 2006, 2007, 2008, 2009, 2011 Free Software Foundation, Inc. This file is part of the GNU C Library. Written by Per Bothner <bothner@cygnus.com>. @@ -290,7 +290,7 @@ _IO_new_file_fopen (fp, filename, mode, is32not64) #ifdef _LIBC last_recognized = mode; #endif - for (i = 1; i < 6; ++i) + for (i = 1; i < 7; ++i) { switch (*++mode) { -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
next reply other threads:[~2011-04-20 0:46 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-04-20 0:46 eblake at redhat dot com [this message] 2011-04-20 0:47 ` [Bug libc/12685] fopen doesn't honor " eblake at redhat dot com 2011-04-20 0:52 ` ppluzhnikov at google dot com 2011-04-23 3:42 ` drepper.fsp at gmail dot com 2012-04-22 1:59 ` mtk.manpages at gmail dot com 2012-04-22 2:02 ` mtk.manpages at gmail dot com 2012-04-22 2:12 ` mtk.manpages at gmail dot com 2012-04-22 10:40 ` [Bug stdio/12685] " jsm28 at gcc dot gnu.org 2013-05-09 15:14 ` ondra at iuuk dot mff.cuni.cz 2013-05-09 16:08 ` bugdal at aerifal dot cx 2014-06-27 13:30 ` fweimer at redhat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-12685-131@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sources.redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).