From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26812 invoked by alias); 8 Jul 2011 16:01:10 -0000 Received: (qmail 26802 invoked by uid 22791); 8 Jul 2011 16:01:10 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO sourceware.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Jul 2011 16:00:56 +0000 From: "eblake at redhat dot com" To: glibc-bugs@sources.redhat.com Subject: [Bug libc/12922] getopt dumps core X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: libc X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: eblake at redhat dot com X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: drepper.fsp at gmail dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Fri, 08 Jul 2011 16:01:00 -0000 Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: glibc-bugs-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00032.txt.bz2 http://sourceware.org/bugzilla/show_bug.cgi?id=12922 --- Comment #5 from Eric Blake 2011-07-08 16:00:53 UTC --- (In reply to comment #4) > (In reply to comment #3) > > Except that your patch fails to compile with C89 compilers. > > Who cares? Right now, gnulib and glibc getopt.c are intentionally kept in sync. This is because _lots_ of projects use getopt.c verbatim in their projects when compiling on non-glibc platforms. And this includes with C89 compilers. If you truly don't care about projects that want to port getopt.c outside of glibc, then there is a LOT of cruft that can be removed (look at all the #ifdef _LIBC stuff at the top of the file). By keeping that portability headache, it implies that you want to keep this file portable, and that (unfortunately) still implies using C89 throughout the file. -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.