[Bug libc/13067] New: obstack_free casts char* to int

[Bug libc/13067] New: obstack_free casts char* to int

[marc.glisse at normalesup dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=13067

           Summary: obstack_free casts char* to int
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper.fsp@gmail.com
        ReportedBy: marc.glisse@normalesup.org


Created attachment 5885
  --> http://sourceware.org/bugzilla/attachment.cgi?id=5885
Cast to char*

Hello,

in malloc/obstack.h, the version of obstack_free for non-gnu or non-stdc casts
a pointer to an int. The result is ignored, so that's not a problem, except
that it may cause compilation warnings or even errors (in C++). The cast is
done to match the type of 0 in the ?: alternative. The patch instead casts 0 to
char*.

I originally posted a similar patch for gcc's version of obstack.h and was
advised to post it here.
http://gcc.gnu.org/ml/gcc-patches/2011-08/msg00758.html

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13067] obstack_free casts char* to int

[marc.glisse at normalesup dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=13067

Marc Glisse <marc.glisse at normalesup dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5885|0                           |1
           is patch|                            |
   Attachment #5885|application/octet-stream    |text/plain
          mime type|                            |

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13067] obstack_free casts char* to int

[drepper.fsp at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13067

Ulrich Drepper <drepper.fsp at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Ulrich Drepper <drepper.fsp at gmail dot com> 2011-09-11 17:04:53 UTC ---
I applied a different change.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13067] obstack_free casts char* to int

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=13067

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.