[Bug libc/13144] New: Incorrect x86-64 bits/sem.h

[Bug libc/13144] New: Incorrect x86-64 bits/sem.h

[hjl.tools at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13144

             Bug #: 13144
           Summary: Incorrect x86-64 bits/sem.h
           Product: glibc
           Version: 2.14
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper.fsp@gmail.com
        ReportedBy: hjl.tools@gmail.com
    Classification: Unclassified


sysdeps/unix/sysv/linux/x86_64/bits/sem.h has

/* Data structure describing a set of semaphores.  */
struct semid_ds
{
  struct ipc_perm sem_perm;        /* operation permission struct */
  __time_t sem_otime;            /* last semop() time */
  unsigned long int __unused1;
  __time_t sem_ctime;            /* last time changed by semctl() */
  unsigned long int __unused2;
  unsigned long int sem_nsems;        /* number of semaphores in set */
  unsigned long int __unused3;
  unsigned long int __unused4;
};

But kernel include/asm-generic/sembuf.h has

struct semid64_ds {
        struct ipc64_perm sem_perm;     /* permissions .. see ipc.h */
        __kernel_time_t sem_otime;      /* last semop time */
#if __BITS_PER_LONG != 64
        unsigned long   __unused1;
#endif
        __kernel_time_t sem_ctime;      /* last change time */
#if __BITS_PER_LONG != 64
        unsigned long   __unused2;
#endif
        unsigned long   sem_nsems;      /* no. of semaphores in array */
        unsigned long   __unused3;
        unsigned long   __unused4;
};

unused1 and unused2 fields should be protected with

#if __WORDSIZE == 32
#endif

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13144] Incorrect x86-64 bits/sem.h

[ppluzhnikov at google dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13144

Paul Pluzhnikov <ppluzhnikov at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ppluzhnikov at google dot
                   |                            |com

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13144] Incorrect x86-64 bits/sem.h

[drepper.fsp at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13144

Ulrich Drepper <drepper.fsp at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Ulrich Drepper <drepper.fsp at gmail dot com> 2011-09-05 16:45:02 UTC ---
Changed in git.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13144] Incorrect x86-64 bits/sem.h

[schwab@linux-m68k.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=13144

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED
         Resolution|FIXED                       |INVALID

--- Comment #2 from Andreas Schwab <schwab@linux-m68k.org> 2011-09-07 12:40:26 UTC ---
x86_64 does not use the asm-generic version of semid64_ds.  The correct
definition is in arch/x86/include/asm/sembuf.h.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/13144] Incorrect x86-64 bits/sem.h

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=13144

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.