From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <glibc-bugs-return-13517-listarch-glibc-bugs=sources.redhat.com@sourceware.org>
Received: (qmail 30681 invoked by alias); 24 Oct 2011 15:04:31 -0000
Received: (qmail 30639 invoked by uid 22791); 24 Oct 2011 15:04:29 -0000
X-SWARE-Spam-Status: No, hits=-2.8 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO sourceware.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Oct 2011 15:04:13 +0000
From: "thomas.jarosch at intra2net dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sources.redhat.com
Subject: [Bug libc/13337] New: load_shobj(): Fix readlink() buffer termination handling
Date: Mon, 24 Oct 2011 15:04:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: libc
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: thomas.jarosch at intra2net dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: drepper.fsp at gmail dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
Message-ID: <bug-13337-131@http.sourceware.org/bugzilla/>
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <glibc-bugs.sourceware.org>
List-Subscribe: <mailto:glibc-bugs-subscribe@sourceware.org>
List-Post: <mailto:glibc-bugs@sourceware.org>
List-Help: <mailto:glibc-bugs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: glibc-bugs-owner@sourceware.org
X-SW-Source: 2011-10/txt/msg00158.txt.bz2

http://sourceware.org/bugzilla/show_bug.cgi?id=13337

             Bug #: 13337
           Summary: load_shobj(): Fix readlink() buffer termination
                    handling
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper.fsp@gmail.com
        ReportedBy: thomas.jarosch@intra2net.com
    Classification: Unclassified


Created attachment 6029
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6029
Patch to fix the issue

>>From the patch:

load_shobj(): Fix readlink() buffer termination handling

readlink() never zero terminates the buffer.
load_shobj() calls readlink() like this:

   "if (readlink (origprocname, origlink, PATH_MAX) == -1)"

It tried to compensate for the missing zero termination
with this line of code:

    origlink[PATH_MAX] = '\0';

This is wrong as the content of the 'origlink' buffer
will probably be shorter than PATH_MAX and therefore
contains an unterminated string + garbage.

Fix it by terminating the string properly. Also lower
the buffer size to PATH_MAX, that should be more than enough.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.