public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sources.redhat.com
Subject: [Bug nptl/13344] Marking all functions which don't have callbacks with the leaf attribute breaks pthread applications.
Date: Tue, 25 Oct 2011 20:39:00 -0000	[thread overview]
Message-ID: <bug-13344-131-s9CDm2Vd0P@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-13344-131@http.sourceware.org/bugzilla/>

http://sourceware.org/bugzilla/show_bug.cgi?id=13344

--- Comment #1 from Jakub Jelinek <jakub at redhat dot com> 2011-10-25 20:38:30 UTC ---
I think the leaf attribute in gcc is currently primarily used by ipa-reference
to find out what variables are supposed not to be read resp. written during the
call to that function (with leaf attribute all static vars in the current
translation unit are in that set if the leaf function is defined in some other
compilation unit) and for checking whether labels can be reached by non-local
goto.  While the synchronization primitives don't call any callbacks, from this
POV it is undesirable to treat them that way, they need to be considered as
full barriers.  I think the GCC documentation of leaf attribute should be
improved and the pthread.h/sem.h functions that are supposed to work as memory
synchronization points should use __THROWNL or similar macro which would be the
old __THROW, without leaf attribute in it.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


  parent reply	other threads:[~2011-10-25 20:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-25 18:20 [Bug nptl/13344] New: " cryptooctoploid at gmail dot com
2011-10-25 20:32 ` [Bug nptl/13344] " jakub at redhat dot com
2011-10-25 20:39 ` jakub at redhat dot com [this message]
2011-10-25 20:52 ` jakub at redhat dot com
2011-10-26  6:55 ` jim at meyering dot net
2011-10-27 16:41 ` cryptooctoploid at gmail dot com
2014-06-27 11:44 ` fweimer at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-13344-131-s9CDm2Vd0P@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).