public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "aj at suse dot de" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sources.redhat.com
Subject: [Bug libc/13446] crash in vfprintf with more than 64 format args and format specifiers
Date: Sun, 18 Dec 2011 06:33:00 -0000	[thread overview]
Message-ID: <bug-13446-131-fVjMEqTiLI@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-13446-131@http.sourceware.org/bugzilla/>

http://sourceware.org/bugzilla/show_bug.cgi?id=13446

Andreas Jaeger <aj at suse dot de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #7 from Andreas Jaeger <aj at suse dot de> 2011-12-18 06:32:26 UTC ---
The patch is wrong, you need to increase nspecs_size in the for loop if you do
a new alloca call.

Otherwise you call alloca every time with nspecs_size*2  - and eventually
override the array

Add after:
 specs = extend_alloca (specs, nspecs_size, 2 * nspecs_size);

a line with:
 nspecs_size = 2 * nspecs_size;

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


  parent reply	other threads:[~2011-12-18  6:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29  3:37 [Bug libc/13446] New: " rcoe at wi dot rr.com
2011-11-29  3:39 ` [Bug libc/13446] " rcoe at wi dot rr.com
2011-11-29  8:56 ` aj at suse dot de
2011-11-29 10:39 ` aj at suse dot de
2011-11-29 12:23 ` rcoe at wi dot rr.com
2011-12-05 12:44 ` gnu at pontohonk dot de
2011-12-18  2:29 ` drepper.fsp at gmail dot com
2011-12-18  6:33 ` aj at suse dot de [this message]
2011-12-18  9:11 ` schwab@linux-m68k.org
2014-02-16 19:42 ` jackie.rosen at hushmail dot com
2014-05-28 19:40 ` schwab at sourceware dot org
2014-06-14 22:31 ` vapier at gentoo dot org
2014-06-14 22:35 ` vapier at gentoo dot org
2014-06-16 12:20 ` [Bug libc/13446] crash in vfprintf with more than 64 format args and format specifiers (CVE-2012-3405) fweimer at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-13446-131-fVjMEqTiLI@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).