From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1381 invoked by alias); 14 Jul 2015 20:23:47 -0000 Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: glibc-bugs-owner@sourceware.org Received: (qmail 1257 invoked by uid 48); 14 Jul 2015 20:23:43 -0000 From: "triegel at redhat dot com" To: glibc-bugs@sourceware.org Subject: [Bug nptl/13690] pthread_mutex_unlock potentially cause invalid access Date: Tue, 14 Jul 2015 20:23:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: nptl X-Bugzilla-Version: 2.15 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: triegel at redhat dot com X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: 2.18 X-Bugzilla-Flags: review? X-Bugzilla-Changed-Fields: bug_status target_milestone Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-07/txt/msg00102.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D13690 Torvald Riegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Target Milestone|2.22 |2.18 --- Comment #51 from Torvald Riegel --- The spurious wake-up issue has been discussed with the Kernel community, and the conclusion was to essentially document this behavior. A current draft = of an updated futex manpage has the following wording: FUTEX_WAIT Returns 0 if the caller was woken up. Note that a wake-up = can also be caused by common futex usage patterns in unrelated c= ode that happened to have previously used the futex word's mem= ory location (e.g., typical futex-based implementations of Pthre= ads mutexes can cause this under some conditions). Therefore, ca= ll=E2=80=90 ers should always conservatively assume that a return value o= f 0 can mean a spurious wake-up, and use the futex word's va= lue (i.e., the user space synchronization scheme) to decide whether to continue to block or not. I've send an updated patch for review: https://sourceware.org/ml/libc-alpha/2015-07/msg00411.html Compared to the patch posted here, it fixes the problem in __lll_unlock and __lll_robust_unlock, and fixes a similar problem in __pthread_mutex_unlock_full. --=20 You are receiving this mail because: You are on the CC list for the bug. >>From glibc-bugs-return-28823-listarch-glibc-bugs=sources.redhat.com@sourceware.org Tue Jul 14 20:38:23 2015 Return-Path: Delivered-To: listarch-glibc-bugs@sources.redhat.com Received: (qmail 27496 invoked by alias); 14 Jul 2015 20:38:23 -0000 Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: glibc-bugs-owner@sourceware.org Delivered-To: mailing list glibc-bugs@sourceware.org Received: (qmail 27427 invoked by uid 48); 14 Jul 2015 20:38:10 -0000 From: "dcb314 at hotmail dot com" To: glibc-bugs@sourceware.org Subject: [Bug ports/18674] New: trunk/sysdeps/i386/tst-auditmod3b.c:84: possible missing break ? Date: Tue, 14 Jul 2015 20:38:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: ports X-Bugzilla-Version: 2.21 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dcb314 at hotmail dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-07/txt/msg00103.txt.bz2 Content-length: 943 https://sourceware.org/bugzilla/show_bug.cgi?id=18674 Bug ID: 18674 Summary: trunk/sysdeps/i386/tst-auditmod3b.c:84: possible missing break ? Product: glibc Version: 2.21 Status: NEW Severity: normal Priority: P2 Component: ports Assignee: unassigned at sourceware dot org Reporter: dcb314 at hotmail dot com CC: carlos at redhat dot com, roland at gnu dot org Target Milestone: --- [trunk/sysdeps/i386/tst-auditmod3b.c:84] -> [trunk/sysdeps/i386/tst-auditmod3b.c:86]: (warning) Variable 'flagstr' is reassigned a value before the old one has been used. 'break;' missing? Source code is case LA_SER_DEFAULT: flagstr = "LA_SER_DEFAULT"; case LA_SER_SECURE: flagstr = "LA_SER_SECURE"; break; -- You are receiving this mail because: You are on the CC list for the bug.