[Bug libc/14150] New: get rid of ASM_TYPE_DIRECTIVE{,_PREFIX}

[Bug libc/14150] New: get rid of ASM_TYPE_DIRECTIVE{,_PREFIX}

[roland at gnu dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14150

             Bug #: 14150
           Summary: get rid of ASM_TYPE_DIRECTIVE{,_PREFIX}
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: unassigned@sourceware.org
        ReportedBy: roland@gnu.org
                CC: drepper.fsp@gmail.com
    Classification: Unclassified


We only support ELF now, so ASM_TYPE_DIRECTIVE is no longer necessary--we can
just use .type unconditionally.

We require fairly recent binutils and don't attempt to support non-GNU
assemblers.  GAS recognizes any of @ # % as the prefix for the type name.  Of
these, @ and # are the comment characters on some machines, but % works (AFAIK)
for every machine.  So we can get rid of ASM_TYPE_DIRECTIVE_PREFIX and just use
% everywhere.  GAS also supports the syntax: .type SYMBOL,"TYPE" (with
double-quotes) so that could be the new norm, though % seems slightly
preferable to me.

This could be done in multiple stages, but it's probably not worth dragging it
out.
1. Remove the configure test and just define the macro unconditionally either
in config.h.in or in libc-symbols.h (for each macro, could even be 1a and 1b
steps).
2. Change all uses of the macro to just use direct assembler syntax.
3. Remove the macro.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/14150] get rid of ASM_TYPE_DIRECTIVE{,_PREFIX}

[polacek at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14150

Marek Polacek <polacek at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |polacek at redhat dot com
   Target Milestone|---                         |2.17

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/14150] get rid of ASM_TYPE_DIRECTIVE{,_PREFIX}

[polacek at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14150

Marek Polacek <polacek at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at sourceware    |polacek at redhat dot com
                   |dot org                     |

--- Comment #1 from Marek Polacek <polacek at redhat dot com> 2012-07-09 11:44:50 UTC ---
Mine.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/14150] get rid of ASM_TYPE_DIRECTIVE{,_PREFIX}

[polacek at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14150

--- Comment #2 from Marek Polacek <polacek at redhat dot com> 2012-07-27 17:06:15 UTC ---
Created attachment 6560
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6560
Untested fix

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/14150] get rid of ASM_TYPE_DIRECTIVE{,_PREFIX}

[polacek at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14150

Marek Polacek <polacek at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/14150] get rid of ASM_TYPE_DIRECTIVE{,_PREFIX}

[polacek at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14150

Marek Polacek <polacek at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Marek Polacek <polacek at redhat dot com> 2012-08-02 19:08:28 UTC ---
Fixed.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/14150] get rid of ASM_TYPE_DIRECTIVE{,_PREFIX}

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14150

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.