[Bug libc/14151] New: get rid of ASM_GLOBAL_DIRECTIVE

[Bug libc/14151] New: get rid of ASM_GLOBAL_DIRECTIVE

[roland at gnu dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14151

             Bug #: 14151
           Summary: get rid of ASM_GLOBAL_DIRECTIVE
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: unassigned@sourceware.org
        ReportedBy: roland@gnu.org
                CC: drepper.fsp@gmail.com
    Classification: Unclassified


We require fairly recent binutils and don't attempt to support non-GNU
assemblers.  GAS recognizes both .globl and .global regardless of machine.
So we can just use .globl (I prefer it to .global since .globl is the original
traditional syntax).

This could be done in multiple stages but probably isn't worth the trouble.
1. Remove the configure test and just define the macro unconditionally either
in config.h.in or in libc-symbols.h.
2. Remove all uses of the macro.
3. Remove the macro.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/14151] get rid of ASM_GLOBAL_DIRECTIVE

[polacek at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14151

Marek Polacek <polacek at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |polacek at redhat dot com

--- Comment #1 from Marek Polacek <polacek at redhat dot com> 2012-05-31 16:31:17 UTC ---
So, if we do this in a single step, we will be using just a plain ".globl"
string everywhere, not any macro?  Wouldn't it be better to just remove
configure test and define that macro unconditionally?

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/14151] get rid of ASM_GLOBAL_DIRECTIVE

[polacek at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14151

Marek Polacek <polacek at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at sourceware    |polacek at redhat dot com
                   |dot org                     |

--- Comment #2 from Marek Polacek <polacek at redhat dot com> 2012-05-31 16:37:03 UTC ---
Either way, I'm taking this one.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/14151] get rid of ASM_GLOBAL_DIRECTIVE

[roland at gnu dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14151

--- Comment #3 from Roland McGrath <roland at gnu dot org> 2012-05-31 22:39:34 UTC ---
(In reply to comment #1)
> So, if we do this in a single step, we will be using just a plain ".globl"
> string everywhere, not any macro?  Wouldn't it be better to just remove
> configure test and define that macro unconditionally?

The end state should be no macro, since we'll never need this to vary.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/14151] get rid of ASM_GLOBAL_DIRECTIVE

[polacek at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14151

Marek Polacek <polacek at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.17

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/14151] get rid of ASM_GLOBAL_DIRECTIVE

[polacek at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14151

Marek Polacek <polacek at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Marek Polacek <polacek at redhat dot com> 2012-07-10 13:31:12 UTC ---
Fixed by 7b8e0d49cbfd8a911978d4b72f3d97e11a6d34ec.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/14151] get rid of ASM_GLOBAL_DIRECTIVE

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14151

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.