[Bug hurd/14280] New: hurd ioctl request definitions produce warning: enumeral and non-enumeral type in conditional expression

[Bug hurd/14280] New: hurd ioctl request definitions produce warning: enumeral and non-enumeral type in conditional expression

[andersk at mit dot edu]

http://sourceware.org/bugzilla/show_bug.cgi?id=14280

             Bug #: 14280
           Summary: hurd ioctl request definitions produce warning:
                    enumeral and non-enumeral type in conditional
                    expression
           Product: glibc
           Version: 2.15
            Status: NEW
          Severity: normal
          Priority: P2
         Component: hurd
        AssignedTo: unassigned@sourceware.org
        ReportedBy: andersk@mit.edu
                CC: roland@gnu.org, tschwinge@sourceware.org
    Classification: Unclassified


On HURD, any use of the ioctl request values defined in
sysdeps/mach/hurd/bits/ioctls.h (e.g. TIOCGWINSZ) produces this warning with
-Wextra:

warning: enumeral and non-enumeral type in conditional expression [enabled by
default]

Patch:

diff --git a/sysdeps/mach/hurd/bits/ioctls.h b/sysdeps/mach/hurd/bits/ioctls.h
index c4cfce6..7363173 100644
--- a/sysdeps/mach/hurd/bits/ioctls.h
+++ b/sysdeps/mach/hurd/bits/ioctls.h
@@ -141,7 +141,7 @@ enum __ioctl_datum { IOC_8, IOC_16, IOC_32, IOC_64 };

 /* Construct an individual type field for TYPE.  */
 #define _IOTS(type)    \
-  (sizeof (type) == 8 ? IOC_64 : (sizeof (type) >> 1))
+  (sizeof (type) == 8 ? (unsigned long) IOC_64 : (sizeof (type) >> 1))

 /* Construct a type information field for
    a single argument of the scalar TYPE.  */

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug hurd/14280] hurd ioctl request definitions produce warning: enumeral and non-enumeral type in conditional expression

[keithw at mit dot edu]

http://sourceware.org/bugzilla/show_bug.cgi?id=14280

Keith Winstein <keithw at mit dot edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |keithw at mit dot edu

--- Comment #1 from Keith Winstein <keithw at mit dot edu> 2013-03-28 03:03:07 UTC ---
We'd appreciate if somebody could take a look at this. It continues to break
the build for Mosh on Debian hurd-i386
(https://buildd.debian.org/status/package.php?p=mosh). Happy to supply more
information if necessary.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug hurd/14280] hurd ioctl request definitions produce warning: enumeral and non-enumeral type in conditional expression

[roland at gnu dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14280

Roland McGrath <roland at gnu dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Roland McGrath <roland at gnu dot org> 2013-04-08 21:35:25 UTC ---
I put it a slightly different fix.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug hurd/14280] hurd ioctl request definitions produce warning: enumeral and non-enumeral type in conditional expression

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14280

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.