[Bug nptl/14303] New: rpcgen looks for "cpp" in /lib, but not in /usr/bin

[Bug nptl/14303] New: rpcgen looks for "cpp" in /lib, but not in /usr/bin

[arjan at linux dot intel.com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14303

             Bug #: 14303
           Summary: rpcgen looks for "cpp" in /lib, but not in /usr/bin
           Product: glibc
           Version: 2.15
            Status: NEW
          Severity: normal
          Priority: P2
         Component: nptl
        AssignedTo: unassigned@sourceware.org
        ReportedBy: arjan@linux.intel.com
                CC: drepper.fsp@gmail.com
    Classification: Unclassified


Created attachment 6491
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6491
add /usr/bin to the places to search

attached patch solves the issue

rpcgen by default looks for /lib/cpp only (well and some sun specific weird
path), but not in "/usr/bin", where gcc installs it. gcc does not install a
/lib/cpp symlink. (although many distros manually add it, I suppose for
rpcgen's sake)

patch makes it look also in /usr/bin.
I had to restructure the code slightly to avoid having a 3rd nested if, but
it's really only 3 new lines of code

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug nis/14303] rpcgen looks for "cpp" in /lib, but not in /usr/bin

[arjan at linux dot intel.com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14303

Arjan van de Ven <arjan at linux dot intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kukuk at suse dot de
          Component|nptl                        |nis

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug nis/14303] rpcgen looks for "cpp" in /lib, but not in /usr/bin

[aj at suse dot de]

http://sourceware.org/bugzilla/show_bug.cgi?id=14303

Andreas Jaeger <aj at suse dot de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6491|0                           |1
           is patch|                            |
   Attachment #6491|application/octet-stream    |text/plain
          mime type|                            |

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug nis/14303] rpcgen looks for "cpp" in /lib, but not in /usr/bin

[allan at archlinux dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14303

Allan McRae <allan at archlinux dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |allan at archlinux dot org

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug nis/14303] rpcgen looks for "cpp" in /lib, but not in /usr/bin

[allan at archlinux dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14303

--- Comment #1 from Allan McRae <allan at archlinux dot org> 2012-07-06 15:40:20 UTC ---
There are other patches floating around to do this.

The one attached to https://bugzilla.redhat.com/show_bug.cgi?id=456089 makes an
array of paths to search.  That would be easier to extend.

Others use execvp to call cpp and so use the system path, although I doubt that
will detect /lib/cpp and /usr/ccs/lib/cpp will not be a PATH so that would not
be backwards compatible.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug nis/14303] rpcgen looks for "cpp" in /lib, but not in /usr/bin

[arjan at linux dot intel.com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14303

--- Comment #2 from Arjan van de Ven <arjan at linux dot intel.com> 2012-07-06 15:48:15 UTC ---
there are obviously many ways to skin this cat
I went for "least invasive to clearly very old code"

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug nis/14303] rpcgen looks for "cpp" in /lib, but not in /usr/bin

[bugdal at aerifal dot cx]

http://sourceware.org/bugzilla/show_bug.cgi?id=14303

Rich Felker <bugdal at aerifal dot cx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugdal at aerifal dot cx

--- Comment #3 from Rich Felker <bugdal at aerifal dot cx> 2012-07-06 17:21:19 UTC ---
Isn't /lib/cpp usually a "traditional" (non-ANSI/ISO-conformant) "C
preprocessor" used for non-C-language config file preprocessing, etc.? I may be
wrong, but if so, it seems like it could be useful/desirable to have this
somewhere outside the normal bin path so that the "cpp" in the path can
actually be a conformant C preprocessor.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug nis/14303] rpcgen looks for "cpp" in /lib, but not in /usr/bin

[aj at suse dot de]

http://sourceware.org/bugzilla/show_bug.cgi?id=14303

Andreas Jaeger <aj at suse dot de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aj at suse dot de

--- Comment #4 from Andreas Jaeger <aj at suse dot de> 2012-07-06 17:26:40 UTC ---
Btw. my system has as /lib/cpp the following script:

#!/bin/sh
# Traditionally, /lib/cpp only knew about C.
exec /usr/bin/cpp -xc "$@"

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug nis/14303] rpcgen looks for "cpp" in /lib, but not in /usr/bin

[arjan at linux dot intel.com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14303

--- Comment #5 from Arjan van de Ven <arjan at linux dot intel.com> 2012-07-06 17:33:18 UTC ---
interesting discussion.

but the real question is .. what does rpcgen expect for its own use
and afaics that's just the normal /usr/bin/cpp anyway.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug nis/14303] rpcgen looks for "cpp" in /lib, but not in /usr/bin

[allan at archlinux dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14303

--- Comment #6 from Allan McRae <allan at archlinux dot org> 2012-07-14 08:25:32 UTC ---
Created attachment 6530
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6530
Use execvp to fall back to system cpp

How about the attached patch using execvp to fall back to using the system cpp?
 This saves hardcoding another path.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug nis/14303] rpcgen looks for "cpp" in /lib, but not in /usr/bin

[allan at archlinux dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14303

--- Comment #7 from Allan McRae <allan at archlinux dot org> 2012-07-14 08:30:18 UTC ---
> what does rpcgen expect for its own use

It appears to need a vey basic C pre-processor so /usr/bin/cpp from gcc is more
than enough.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug nis/14303] rpcgen looks for "cpp" in /lib, but not in /usr/bin

[aj at suse dot de]

http://sourceware.org/bugzilla/show_bug.cgi?id=14303

--- Comment #8 from Andreas Jaeger <aj at suse dot de> 2012-07-25 18:01:37 UTC ---
Allan, I like your patch. could you send it to libc-alpha for review, please?

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug nis/14303] rpcgen looks for "cpp" in /lib, but not in /usr/bin

[aj at suse dot de]

http://sourceware.org/bugzilla/show_bug.cgi?id=14303

Andreas Jaeger <aj at suse dot de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Andreas Jaeger <aj at suse dot de> 2012-08-08 07:20:25 UTC ---
This has been fixed now, thanks for the report.

commit bf9b740a119eecf01499b4de0dc8cbd27b7c47bd
Author: Allan McRae <allan@archlinux.org>
Date:   Sat Aug 4 12:19:09 2012 +1000

    rpcgen - fall back to looking for cpp in system path

    Fall back to the system cpp when /lib/cpp is not present. Removes
    searching for /usr/ccs/lib/cpp which is not supported on any system that
    uses glibc.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug nis/14303] rpcgen looks for "cpp" in /lib, but not in /usr/bin

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14303

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.