public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/14317] New: __xpg_strerror_r not fully optimized
@ 2012-06-30 16:05 bruno at clisp dot org
2012-06-30 16:08 ` [Bug libc/14317] " bruno at clisp dot org
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: bruno at clisp dot org @ 2012-06-30 16:05 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=14317
Bug #: 14317
Summary: __xpg_strerror_r not fully optimized
Product: glibc
Version: 2.16
Status: NEW
Severity: normal
Priority: P2
Component: libc
AssignedTo: unassigned@sourceware.org
ReportedBy: bruno@clisp.org
CC: drepper.fsp@gmail.com
Classification: Unclassified
The implementation of __xpg_strerror_r spends time doing an strlen call,
and then potentially returning before the value is actually used.
This can be optimized.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libc/14317] __xpg_strerror_r not fully optimized
2012-06-30 16:05 [Bug libc/14317] New: __xpg_strerror_r not fully optimized bruno at clisp dot org
@ 2012-06-30 16:08 ` bruno at clisp dot org
2012-07-24 4:10 ` carlos_odonell at mentor dot com
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: bruno at clisp dot org @ 2012-06-30 16:08 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=14317
--- Comment #1 from Bruno Haible <bruno at clisp dot org> 2012-06-30 16:08:34 UTC ---
Created attachment 6502
--> http://sourceware.org/bugzilla/attachment.cgi?id=6502
proposed fix
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libc/14317] __xpg_strerror_r not fully optimized
2012-06-30 16:05 [Bug libc/14317] New: __xpg_strerror_r not fully optimized bruno at clisp dot org
2012-06-30 16:08 ` [Bug libc/14317] " bruno at clisp dot org
@ 2012-07-24 4:10 ` carlos_odonell at mentor dot com
2012-12-01 17:05 ` aj at suse dot de
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: carlos_odonell at mentor dot com @ 2012-07-24 4:10 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=14317
Carlos O'Donell <carlos_odonell at mentor dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |WAITING
CC| |carlos_odonell at mentor
| |dot com
--- Comment #2 from Carlos O'Donell <carlos_odonell at mentor dot com> 2012-07-24 04:10:04 UTC ---
Bruno,
Fold the copyright years together e.g. 1991-2012.
If you haven't posted this to libc-alpha, please do and I'll ack.
This looks like a straight forward and useful optimization.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libc/14317] __xpg_strerror_r not fully optimized
2012-06-30 16:05 [Bug libc/14317] New: __xpg_strerror_r not fully optimized bruno at clisp dot org
2012-06-30 16:08 ` [Bug libc/14317] " bruno at clisp dot org
2012-07-24 4:10 ` carlos_odonell at mentor dot com
@ 2012-12-01 17:05 ` aj at suse dot de
2012-12-03 15:39 ` aj at suse dot de
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: aj at suse dot de @ 2012-12-01 17:05 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=14317
Andreas Jaeger <aj at suse dot de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|WAITING |ASSIGNED
CC| |aj at suse dot de
AssignedTo|unassigned at sourceware |aj at suse dot de
|dot org |
--- Comment #3 from Andreas Jaeger <aj at suse dot de> 2012-12-01 17:05:12 UTC ---
I cleaned up the patch and send it to libc-alpha myself.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libc/14317] __xpg_strerror_r not fully optimized
2012-06-30 16:05 [Bug libc/14317] New: __xpg_strerror_r not fully optimized bruno at clisp dot org
` (2 preceding siblings ...)
2012-12-01 17:05 ` aj at suse dot de
@ 2012-12-03 15:39 ` aj at suse dot de
2012-12-03 23:59 ` carlos at systemhalted dot org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: aj at suse dot de @ 2012-12-03 15:39 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=14317
Andreas Jaeger <aj at suse dot de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P2 |P1
Target Milestone|--- |2.18
--- Comment #4 from Andreas Jaeger <aj at suse dot de> 2012-12-03 15:38:46 UTC ---
Targeting for 2.18 now.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libc/14317] __xpg_strerror_r not fully optimized
2012-06-30 16:05 [Bug libc/14317] New: __xpg_strerror_r not fully optimized bruno at clisp dot org
` (3 preceding siblings ...)
2012-12-03 15:39 ` aj at suse dot de
@ 2012-12-03 23:59 ` carlos at systemhalted dot org
2012-12-27 21:43 ` aj at suse dot de
2014-06-18 4:28 ` fweimer at redhat dot com
6 siblings, 0 replies; 8+ messages in thread
From: carlos at systemhalted dot org @ 2012-12-03 23:59 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=14317
Carlos O'Donell <carlos at systemhalted dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|carlos_odonell at mentor |carlos at systemhalted dot
|dot com |org
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libc/14317] __xpg_strerror_r not fully optimized
2012-06-30 16:05 [Bug libc/14317] New: __xpg_strerror_r not fully optimized bruno at clisp dot org
` (4 preceding siblings ...)
2012-12-03 23:59 ` carlos at systemhalted dot org
@ 2012-12-27 21:43 ` aj at suse dot de
2014-06-18 4:28 ` fweimer at redhat dot com
6 siblings, 0 replies; 8+ messages in thread
From: aj at suse dot de @ 2012-12-27 21:43 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=14317
Andreas Jaeger <aj at suse dot de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #5 from Andreas Jaeger <aj at suse dot de> 2012-12-27 21:42:42 UTC ---
Committed for glibc 2.18:
commit 7fffbdfff7d39cec0783e5b9381fa4093484c235
Author: 2012-12-27 Bruno Haible <bruno@clisp.org>
Date: Thu Dec 27 22:37:39 2012 +0100
BZ#14317: Optimze __xpg_strerror_r
[BZ #14317]
* string/xpg-strerror.c (__xpg_strerror_r): Optimize, call
strlen only if needed.
thanks for the patch!
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libc/14317] __xpg_strerror_r not fully optimized
2012-06-30 16:05 [Bug libc/14317] New: __xpg_strerror_r not fully optimized bruno at clisp dot org
` (5 preceding siblings ...)
2012-12-27 21:43 ` aj at suse dot de
@ 2014-06-18 4:28 ` fweimer at redhat dot com
6 siblings, 0 replies; 8+ messages in thread
From: fweimer at redhat dot com @ 2014-06-18 4:28 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=14317
Florian Weimer <fweimer at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |security-
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-06-18 4:28 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-30 16:05 [Bug libc/14317] New: __xpg_strerror_r not fully optimized bruno at clisp dot org
2012-06-30 16:08 ` [Bug libc/14317] " bruno at clisp dot org
2012-07-24 4:10 ` carlos_odonell at mentor dot com
2012-12-01 17:05 ` aj at suse dot de
2012-12-03 15:39 ` aj at suse dot de
2012-12-03 23:59 ` carlos at systemhalted dot org
2012-12-27 21:43 ` aj at suse dot de
2014-06-18 4:28 ` fweimer at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).