public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hjl.tools at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sources.redhat.com
Subject: [Bug dynamic-link/14370] ld.so crashes on mismatched TLS/non-TLS symbols
Date: Tue, 04 Sep 2012 22:22:00 -0000	[thread overview]
Message-ID: <bug-14370-131-ZlfwLPDKYc@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-14370-131@http.sourceware.org/bugzilla/>

http://sourceware.org/bugzilla/show_bug.cgi?id=14370

--- Comment #20 from H.J. Lu <hjl.tools at gmail dot com> 2012-09-04 22:22:26 UTC ---
(In reply to comment #18)
> (In reply to comment #17)
> > Here are before and after timings of "make all" and "make check".
> 
> H.J., Thanks for working on this...
> 
> This looks like your patch *improved* performance, of which I'm skeptical
> because it adds more instructions into the _dl_symbol_lookup_x hot path.

The performance impact is too small to be visible unless most
of time is spent in _dl_symbol_lookup_x.


> Are the build times from a cold reboot or after a "flush" to ensure the
> previous build didn't change the numbers?

No, I just built them twice without reboot.

> I don't like it that ld.so crashes, but I'm not sold that this is the best
> solution, but it certainly makes the dynamic linker more rugged and perhaps
> avoids what could possibly be used as an attack vector for a security breach.

Same here.

> Please post this to libc-alpha for wide review.

Done.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


  parent reply	other threads:[~2012-09-04 22:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-18 10:05 [Bug dynamic-link/14370] New: SIGFPE in 'ldd -r' pluto at agmk dot net
2012-07-18 10:11 ` [Bug dynamic-link/14370] " aj at suse dot de
2012-07-18 10:49 ` pluto at agmk dot net
2012-07-18 10:54 ` jakub at redhat dot com
2012-07-18 11:00 ` pluto at agmk dot net
2012-07-18 12:37 ` pluto at agmk dot net
2012-07-24  2:04 ` carlos_odonell at mentor dot com
2012-07-24  6:14 ` pluto at agmk dot net
2012-09-02 20:00 ` hjl.tools at gmail dot com
2012-09-02 22:57 ` hjl.tools at gmail dot com
2012-09-03  2:54 ` bugdal at aerifal dot cx
2012-09-03 13:39 ` carlos_odonell at mentor dot com
2012-09-03 15:29 ` pluto at agmk dot net
2012-09-03 18:59 ` hjl.tools at gmail dot com
2012-09-03 20:07 ` aj at suse dot de
2012-09-04 19:09 ` [Bug dynamic-link/14370] ld.so crashes on mismatched TLS/non-TLS symbols hjl.tools at gmail dot com
2012-09-04 19:41 ` carlos_odonell at mentor dot com
2012-09-04 21:32 ` hjl.tools at gmail dot com
2012-09-04 22:03 ` carlos_odonell at mentor dot com
2012-09-04 22:15 ` bugdal at aerifal dot cx
2012-09-04 22:22 ` hjl.tools at gmail dot com [this message]
2012-09-04 23:26 ` bugdal at aerifal dot cx
2012-09-05 15:24 ` ppluzhnikov at google dot com
2012-09-05 15:30 ` hjl.tools at gmail dot com
2012-12-04  0:00 ` carlos at systemhalted dot org
2013-10-02 22:44 ` neleai at seznam dot cz
2014-06-17 18:59 ` fweimer at redhat dot com
2023-07-30 16:53 ` sam at gentoo dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-14370-131-ZlfwLPDKYc@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).