public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "bugdal at aerifal dot cx" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug nptl/14485] File corruption race condition in robust mutex unlocking Date: Wed, 25 Jun 2014 15:47:00 -0000 [thread overview] Message-ID: <bug-14485-131-MaA7XpwIdv@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-14485-131@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=14485 --- Comment #3 from Rich Felker <bugdal at aerifal dot cx> --- The corruption is performed by the kernel when it walks the robust list. The basic situation is the same as in PR #13690, except that here there's actually a potential write to the memory rather than just a read. The sequence of events leading to corruption goes like this: 1. Thread A unlocks the process-shared, robust mutex and is preempted after the mutex is removed from the robust list and atomically unlocked, but before it's removed from the list_op_pending field of the robust list header. 2. Thread B locks the mutex, and, knowing by program logic that it's the last user of the mutex, unlocks and unmaps it, allocates/maps something else that gets assigned the same address as the shared mutex mapping, and then exits. 3. The kernel destroys the process, which involves walking each thread's robust list and processing each thread's list_op_pending field of the robust list header. Since thread A has a list_op_pending pointing at the address previously occupied by the mutex, the kernel obliviously "unlocks the mutex" by writing a 0 to the address and futex-waking it. However, the kernel has instead overwritten part of whatever mapping thread A created. If this is private memory it (probably) doesn't matter since the process is ending anyway (but are there race conditions where this can be seen?). If this is shared memory or a shared file mapping, however, the kernel corrupts it. I suspect the race is difficult to hit since thread A has to get preempted at exactly the wrong time AND thread B has to do a fair amount of work without thread A getting scheduled again. So I'm not sure how much luck we'd have getting a test case. -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2014-06-25 15:47 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-08-17 18:52 [Bug nptl/14485] New: " bugdal at aerifal dot cx 2012-08-17 22:34 ` [Bug nptl/14485] " bugdal at aerifal dot cx 2014-06-17 18:35 ` fweimer at redhat dot com 2014-06-25 10:47 ` fweimer at redhat dot com 2014-06-25 15:47 ` bugdal at aerifal dot cx [this message] 2015-02-09 0:28 ` mail at nh2 dot me 2015-02-09 20:41 ` carlos at redhat dot com 2015-02-09 21:13 ` carlos at redhat dot com 2015-02-09 22:51 ` bugdal at aerifal dot cx 2015-02-10 0:18 ` bugdal at aerifal dot cx 2015-02-10 21:57 ` triegel at redhat dot com 2015-02-10 22:17 ` bugdal at aerifal dot cx 2015-08-09 12:29 ` mail at nh2 dot me 2021-10-21 15:42 ` fweimer at redhat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-14485-131-MaA7XpwIdv@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).