public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug nptl/14569] libpthread.a isn't linked in properly
Date: Tue, 15 Sep 2015 15:37:00 -0000	[thread overview]
Message-ID: <bug-14569-131-A4wVtjpGtl@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-14569-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=14569

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, hjl/pthread/2.21 has been created
        at  8de7f5109fb22e8b53a52fe2fb6b50ff6deaba03 (commit)

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8de7f5109fb22e8b53a52fe2fb6b50ff6deaba03

commit 8de7f5109fb22e8b53a52fe2fb6b50ff6deaba03
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 13 06:01:04 2012 -0700

    Use STB_SECONDARY on pthread functions in libc

    Use STB_SECONDARY binding on pthread functions in libc so that they will
    be preempted by definitions in libpthread at link-time as well as at
    run-time.

        * csu/libc-tls.c (__pthread_initialize_minimal): Mark it
        secondary if HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        * nptl/Makefile: Include ../Makeconfig.
        (libc-libpthread-routines): New macro.
        (libc-libpthread-static-only-routines): Likewise.
        (static-only-routines): Add $(libc-libpthread-static-only-routines)
        if $(have-secondary) is yes.
        (routines): Add $(libc-libpthread-routines) if $(have-secondary)
        is yes.
        (CFLAGS-libc-unwind.c): New.
        * nptl/Versions [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.0):
        Add _pthread_cleanup_pop_restore, _pthread_cleanup_push_defer,
        __pthread_getspecific, __pthread_setspecific,
        __pthread_key_create, pthread_once, __pthread_once,
        __pthread_mutex_lock and __pthread_mutex_unlock.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_2.2): Add
        __pthread_rwlock_init, __pthread_rwlock_destroy,
        __pthread_rwlock_rdlock, __pthread_rwlock_wrlock and
        __pthread_rwlock_unlock.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libc:GLIBC_PRIVATE): Add
        __pthread_unwind and __pthread_setcancelstate.
        [HAVE_ASM_SECONDARY_DIRECTIVE] (libpthread:GLIBC_PRIVATE): Add
        __pthread_setcancelstate.
        * nptl/forward.c (pthread_attr_destroy): Don't define if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_attr_init_2_0): Likewise.
        (__pthread_attr_init_2_1): Likewise.
        (pthread_attr_getdetachstate): Likewise.
        (pthread_attr_setdetachstate): Likewise.
        (pthread_attr_getinheritsched): Likewise.
        (pthread_attr_setinheritsched): Likewise.
        (pthread_attr_getschedparam): Likewise.
        (pthread_attr_setschedparam): Likewise.
        (pthread_attr_getschedpolicy): Likewise.
        (pthread_attr_setschedpolicy): Likewise.
        (pthread_attr_getscope): Likewise.
        (pthread_attr_setscope): Likewise.
        (pthread_condattr_destroy): Likewise.
        (pthread_condattr_init): Likewise.
        (__pthread_cond_broadcast_2_0): Likewise.
        (__pthread_cond_broadcast): Likewise.
        (__pthread_cond_destroy_2_0): Likewise.
        (__pthread_cond_destroy): Likewise.
        (__pthread_cond_init_2_0): Likewise.
        (__pthread_cond_init): Likewise.
        (__pthread_cond_signal_2_0): Likewise.
        (__pthread_cond_signal): Likewise.
        (__pthread_cond_wait_2_0): Likewise.
        (__pthread_cond_wait): Likewise.
        (__pthread_cond_timedwait_2_0): Likewise.
        (__pthread_cond_timedwait): Likewise.
        (pthread_equal): Likewise.
        (__pthread_exit): Likewise.
        (pthread_getschedparam): Likewise.
        (pthread_setschedparam): Likewise.
        (pthread_mutex_destroy): Likewise.
        (pthread_mutex_init): Likewise.
        (pthread_mutex_lock): Likewise.
        (pthread_mutex_unlock): Likewise.
        (pthread_self): Likewise.
        (pthread_setcancelstate): Likewise.
        (pthread_setcanceltype): Likewise.
        (__pthread_unwind): Likewise.
        * nptl/libc-cleanup_defer_compat.c: New file.
        * nptl/libc-pthread_attr_destroy.c: Likewise.
        * nptl/libc-pthread_attr_getdetachstate.c: Likewise.
        * nptl/libc-pthread_attr_getinheritsched.c: Likewise.
        * nptl/libc-pthread_attr_getschedparam.c: Likewise.
        * nptl/libc-pthread_attr_getschedpolicy.c: Likewise.
        * nptl/libc-pthread_attr_getscope.c: Likewise.
        * nptl/libc-pthread_attr_init.c: Likewise.
        * nptl/libc-pthread_attr_setdetachstate.c: Likewise.
        * nptl/libc-pthread_attr_setinheritsched.c: Likewise.
        * nptl/libc-pthread_attr_setschedparam.c: Likewise.
        * nptl/libc-pthread_attr_setschedpolicy.c: Likewise.
        * nptl/libc-pthread_attr_setscope.c: Likewise.
        * nptl/libc-pthread_cond_broadcast.c: Likewise.
        * nptl/libc-pthread_cond_destroy.c: Likewise.
        * nptl/libc-pthread_cond_init.c: Likewise.
        * nptl/libc-pthread_cond_signal.c: Likewise.
        * nptl/libc-pthread_cond_timedwait.c: Likewise.
        * nptl/libc-pthread_cond_wait.c: Likewise.
        * nptl/libc-pthread_condattr_destroy.c: Likewise.
        * nptl/libc-pthread_condattr_init.c: Likewise.
        * nptl/libc-pthread_equal.c: Likewise.
        * nptl/libc-pthread_exit.c: Likewise.
        * nptl/libc-pthread_getschedparam.c: Likewise.
        * nptl/libc-pthread_getspecific.c: Likewise.
        * nptl/libc-pthread_key_create.c: Likewise.
        * nptl/libc-pthread_mutex_destroy.c: Likewise.
        * nptl/libc-pthread_mutex_init.c: Likewise.
        * nptl/libc-pthread_mutex_lock.c: Likewise.
        * nptl/libc-pthread_mutex_unlock.c: Likewise.
        * nptl/libc-pthread_once.c: Likewise.
        * nptl/libc-pthread_rwlock_destroy.c: Likewise.
        * nptl/libc-pthread_rwlock_init.c: Likewise.
        * nptl/libc-pthread_rwlock_rdlock.c: Likewise.
        * nptl/libc-pthread_rwlock_unlock.c: Likewise.
        * nptl/libc-pthread_self.c: Likewise.
        * nptl/libc-pthread_setcancelstate.c: Likewise.
        * nptl/libc-pthread_setcanceltype.c: Likewise.
        * nptl/libc-pthread_setschedparam.c: Likewise.
        * nptl/libc-pthread_setspecific.c: Likewise.
        * nptl/libc-unwind.c: Likewise.
        * nptl-init.c (pthread_functions): Don't include secondary
        pthread functions in libc if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.
        * sysdeps/nptl/pthread-functions.h (pthread_functions): Likewise.
        * nptl/pthreadP.h (__pthread_unwind): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_cond_broadcast_2_0): Declare only if not in libc.
        (__pthread_cond_destroy_2_0): Likewise.
        (__pthread_cond_init_2_0): Likewise.
        (__pthread_cond_signal_2_0): Likewise.
        (__pthread_cond_timedwait_2_0): Likewise.
        (__pthread_cond_wait_2_0): Likewise.
        * scripts/abilist.awk: Support secondary symbols.
        * sysdeps/generic/localplt.data: Allow pthread functions.
        * sysdeps/unix/sysv/linux/i386/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/i386/localplt.data: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/64/libc.abilist: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/x32/libc.abilist: Likewise.
        * sysdeps/nptl/bits/libc-lockP.h (PTFAVAIL): Defined as 1 if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_maybe_call): Always call FUNC if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__libc_ptf_call): Likewise.
        (__libc_ptf_call_always): Likewise.
        (__pthread_mutex_init): Don't mark it weak if
        HAVE_ASM_SECONDARY_DIRECTIVE is defined.
        (__pthread_mutex_destroy): Likewise.
        (__pthread_mutex_lock): Likewise.
        (__pthread_mutex_trylock): Likewise.
        (__pthread_mutex_unlock): Likewise.
        (__pthread_mutexattr_init): Likewise.
        (__pthread_mutexattr_destroy): Likewise.
        (__pthread_mutexattr_settype): Likewise.
        (__pthread_rwlock_destroy): Likewise.
        (__pthread_rwlock_rdlock): Likewise.
        (__pthread_rwlock_tryrdlock): Likewise.
        (__pthread_rwlock_wrlock): Likewise.
        (__pthread_rwlock_trywrlock): Likewise.
        (__pthread_rwlock_unlock): Likewise.
        (__pthread_key_create): Likewise.
        (__pthread_setspecific): Likewise.
        (__pthread_getspecific): Likewise.
        (__pthread_once): Likewise.
        (__pthread_initialize): Likewise.
        (__pthread_atfork): Likewise.
        (_pthread_cleanup_push_defer): Likewise.
        (_pthread_cleanup_pop_restore): Likewise.
        (pthread_setcancelstate): Likewise.
        * sysdeps/unix/sysv/linux/x86_64/cancellation.S (__pthread_unwind):
        Likewise.
        * sysdeps/unix/sysv/linux/fatal-prepare.h (FATAL_PREPARE): Always
        call __pthread_setcancelstate if HAVE_ASM_SECONDARY_DIRECTIVE is
        defined.
        * sysdeps/unix/sysv/linux/i386/i486/libc-lowlevellock.S: Make
        __lll_lock_wait_private and __lll_unlock_wake_private weak in
        libc.a.
        * sysdeps/unix/sysv/linux/x86_64/libc-lowlevellock.S: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=e5daf5a6ed7e88493ab4c79d8dc444451a7083b7

commit e5daf5a6ed7e88493ab4c79d8dc444451a7083b7
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Sep 11 05:10:03 2012 -0700

    Place libpthread.a right before libc.a

    GCC driver places -lpthread in --start-group -lgcc -lgcc_eh -lpthread
    -lc --end-group.  Glibc tests should do the same.

        [BZ #14569]
        * Makeconfig (+link-static-before-libc): Also filter out
        $(common-objpfx)nptl/libpthread%.  Remove $(link-libc-static).
        (link-libc-static-tests): Place libpthread.a before libc.a.
        * nptl/Makefile (tests-static): Add tst-cancelx7-static,
        tst-raise1-static and tst-cancel7-static.
        (tests): Likewise.
        * nptl/tst-cancel7-static.c: New file.
        * nptl/tst-cancelx7-static.c: Likewise.
        * nptl/tst-raise1-static.c: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d8f0433371731d83a754ad173215e6a38d712424

commit d8f0433371731d83a754ad173215e6a38d712424
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Sep 11 06:27:40 2015 -0700

    Make pthread_rwlock_destroy/pthread_rwlock_init/weak

        * pthread_rwlock_destroy.c (pthread_rwlock_destroy): Replace
        strong_alias with weak_alias.
        * pthread_rwlock_init.c (pthread_rwlock_init): Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=af345c230d3f2d2b810cfec292188e26c3da5a48

commit af345c230d3f2d2b810cfec292188e26c3da5a48
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Sep 10 13:41:43 2015 -0700

    Add STB_SECONDARY support to conform/linknamespace.pl

        * conform/linknamespace.pl (list_syms): Support STB_SECONDARY.

-----------------------------------------------------------------------

-- 
You are receiving this mail because:
You are on the CC list for the bug.


  parent reply	other threads:[~2015-09-15 15:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-10 21:47 [Bug nptl/14569] New: " hjl.tools at gmail dot com
2012-09-28  7:36 ` [Bug nptl/14569] " davem at davemloft dot net
2012-09-28  7:37 ` davem at davemloft dot net
2014-06-17  4:34 ` fweimer at redhat dot com
2015-09-15 15:37 ` cvs-commit at gcc dot gnu.org [this message]
2015-09-15 21:34 ` cvs-commit at gcc dot gnu.org
2015-09-16  0:12 ` cvs-commit at gcc dot gnu.org
2015-09-16 12:47 ` cvs-commit at gcc dot gnu.org
2015-09-16 12:54 ` cvs-commit at gcc dot gnu.org
2015-09-16 18:17 ` cvs-commit at gcc dot gnu.org
2015-09-16 19:43 ` cvs-commit at gcc dot gnu.org
2015-09-16 20:01 ` cvs-commit at gcc dot gnu.org
2015-09-24 15:52 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-14569-131-A4wVtjpGtl@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).