public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jgunthorpe at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sources.redhat.com
Subject: [Bug ports/14595] New: memset is broken on powerpc 405
Date: Wed, 19 Sep 2012 20:03:00 -0000	[thread overview]
Message-ID: <bug-14595-131@http.sourceware.org/bugzilla/> (raw)


http://sourceware.org/bugzilla/show_bug.cgi?id=14595

             Bug #: 14595
           Summary: memset is broken on powerpc 405
           Product: glibc
           Version: 2.17
            Status: NEW
          Severity: critical
          Priority: P2
         Component: ports
        AssignedTo: unassigned@sourceware.org
        ReportedBy: jgunthorpe@gmail.com
                CC: carlos@systemhalted.org, roland@gnu.org
    Classification: Unclassified


Created attachment 6638
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6638
fixed memset

The use_dcbz path in the hand coded assembly is assuming a 128 byte clear size
for dcbz, but dcbz uses the cache line size and 405 cores only have a 32 byte
cache line. So any clears to 0 that use the dcbz path fail to work.

Some high end PPC's have a 128 byte cache line, but all 405's are 32 byte,
see arch/powerpc/kernel/cputable.c, dcache_bsize assignments. This value
flows from the kernel to glibc's __cache_line_size value which drives
the dcbz step in the generic memset.

Attached is a patch.

Seen while testing on a 405GP.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


             reply	other threads:[~2012-09-19 20:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-19 20:03 jgunthorpe at gmail dot com [this message]
2012-09-19 20:20 ` [Bug ports/14595] " carlos_odonell at mentor dot com
2012-09-25 16:23 ` rsa at us dot ibm.com
2012-09-25 16:25 ` rsa at us dot ibm.com
2012-11-29 15:47 ` [Bug ports/14595] power: " carlos_odonell at mentor dot com
2012-11-29 15:51 ` rsa at us dot ibm.com
2014-06-13 13:57 ` fweimer at redhat dot com
2014-06-13 14:00 ` fweimer at redhat dot com
2014-06-13 15:36 ` jgunthorpe at gmail dot com
2014-06-13 15:44 ` fweimer at redhat dot com
2014-06-13 15:44 ` fweimer at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-14595-131@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).