[Bug build/14660] New: "make check" relies on C-locale output from objdump

[Bug build/14660] New: "make check" relies on C-locale output from objdump

[jrnieder at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14660

             Bug #: 14660
           Summary: "make check" relies on C-locale output from objdump
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
        AssignedTo: unassigned@sourceware.org
        ReportedBy: jrnieder@gmail.com
                CC: carlos@systemhalted.org
    Classification: Unclassified


Trying to build glibc:

 $ mkdir build
 $ cd build
 $ ../configure --prefix=$HOME/opt/glibc CC=gcc-4.6
[...]
 $ make check
[...]
 objdump --dynamic-syms [...]/build/locale/libBrokenLocale.so >
[...]/build/locale/libBrokenLocale.dynsymT
 mv -f [...]/build/locale/libBrokenLocale.dynsymT
[...]/build/locale/libBrokenLocale.dynsym
 LC_ALL=C gawk -f ../scripts/abilist.awk
[...]/build/locale/libBrokenLocale.dynsym >
[...]/build/locale/libBrokenLocale.symlistT
 mv -f [...]/build/locale/libBrokenLocale.symlistT
[...]/build/locale/libBrokenLocale.symlist
 diff -p -U 0 ../sysdeps/unix/sysv/linux/x86_64/64/nptl/libBrokenLocale.abilist
[...]/build/locale/libBrokenLocale.symlist
 --- ../sysdeps/unix/sysv/linux/x86_64/64/nptl/libBrokenLocale.abilist  
2012-10-02 18:33:50.761863147 -0700
 +++ [...]/build/locale/libBrokenLocale.symlist    2012-10-02
23:45:37.072828817 -0700
 @@ -0,0 +1 @@
 +Don't grok this line: [...]/build/locale/libBrokenLocale.so:     format de
fichier elf64-x86-64
 make[2]: *** [check-abi-libBrokenLocale] Erreur 1

Setting LANG=C when running tests works around it.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug build/14660] "make check" relies on C-locale output from objdump

[jrnieder at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14660

--- Comment #1 from Jonathan Nieder <jrnieder at gmail dot com> 2012-10-03 07:32:20 UTC ---
Created attachment 6662
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6662
Makerules (check-abi-%): force C locale when running objdump

Patch attached.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug build/14660] "make check" relies on C-locale output from objdump

[jrnieder at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14660

Jonathan Nieder <jrnieder at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6662|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Nieder <jrnieder at gmail dot com> 2012-10-03 07:39:54 UTC ---
Created attachment 6663
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6663
Makerules (check-abi-%): force C locale when running objdump

Including the bug number in the changelog entry this time. Sorry for the noise.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug build/14660] "make check" relies on C-locale output from objdump

[aj at suse dot de]

http://sourceware.org/bugzilla/show_bug.cgi?id=14660

Andreas Jaeger <aj at suse dot de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aj at suse dot de

--- Comment #3 from Andreas Jaeger <aj at suse dot de> 2012-10-04 12:54:30 UTC ---
The patch looks fine. Could you send it to libc-alpha so that somebody else
commits it, please?

I suggest the following change:
* Send the changelog entry as plain text, not as a diff

Thanks!

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug build/14660] "make check" relies on C-locale output from objdump

[jrnieder at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14660

--- Comment #4 from Jonathan Nieder <jrnieder at gmail dot com> 2012-10-08 20:57:10 UTC ---
Andreas Jaeger wrote:

> The patch looks fine. Could you send it to libc-alpha

Done, thanks.

I use git-merge-changelog from gnulib to cleanly apply patches with
ChangeLog changes with "git am -3".  It works like this:

    # get gnulib
    git clone git://git.sv.gnu.org/gnulib
    cd gnulib

    # build, as described in lib/git-merge-changelog.c
    ./gnulib-tool --create-testdir \
      --dir=$HOME/src/git-merge-changelog git-merge-changelog
    cd $HOME/src/git-merge-changelog
    ./configure
    make

    # install
    ln -s ../src/git-merge-changelog/gllib/git-merge-changelog $HOME/bin/
    cat <<-\EOF >>$HOME/.gitconfig
    [merge "changelog"]
        name = gnulib changelog merge
        driver = git merge-changelog %O %A %B
    EOF

    # use it
    echo 'ChangeLog merge=changelog' >>~/src/glibc/.git/info/attributes

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug build/14660] "make check" relies on C-locale output from objdump

[jrnieder at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14660

Jonathan Nieder <jrnieder at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Jonathan Nieder <jrnieder at gmail dot com> 2012-10-08 21:21:01 UTC ---
commit 55f11534
Author: Jonathan Nieder <jrnieder@gmail.com>
Date:   Mon Oct 8 14:04:15 2012 -0700

    Makerules (check-abi-%): force C locale when running objdump

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug build/14660] "make check" relies on C-locale output from objdump

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14660

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.