public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/14809] New: glibc's sysctl.h thinks it knows the <linux/kernel.h> feature test macro
@ 2012-11-05 20:30 kkeithle at redhat dot com
2012-11-05 20:33 ` [Bug libc/14809] " kkeithle at redhat dot com
` (10 more replies)
0 siblings, 11 replies; 12+ messages in thread
From: kkeithle at redhat dot com @ 2012-11-05 20:30 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=14809
Bug #: 14809
Summary: glibc's sysctl.h thinks it knows the <linux/kernel.h>
feature test macro
Product: glibc
Version: 2.16
Status: NEW
Severity: normal
Priority: P2
Component: libc
AssignedTo: unassigned@sourceware.org
ReportedBy: kkeithle@redhat.com
CC: drepper.fsp@gmail.com
Classification: Unclassified
./sysdeps/unix/sysv/linux/sys/sysctl.h contains:
/* Prevent more kernel headers than necessary to be included. */
#ifndef _LINUX_KERNEL_H
# define _LINUX_KERNEL_H 1
# define __undef_LINUX_KERNEL_H
#endif
#ifndef _LINUX_TYPES_H
# define _LINUX_TYPES_H 1
# define __undef_LINUX_TYPES_H
#endif
#ifndef _LINUX_LIST_H
# define _LINUX_LIST_H 1
# define __undef_LINUX_LIST_H
#endif
#ifndef __LINUX_COMPILER_H
# define __LINUX_COMPILER_H 1
# define __user
# define __undef__LINUX_COMPILER_H
#endif
But starting with kernel 3.7, the feature test macros are _UAPI_LINUX_KERNEL_H
and _UAPI_LINUX_TYPES_H (and no file uses *_LIST_H or *_COMPILER_H AFAICT)
As such the above doesn't work and third party apps that include the
(in)correct mix of header files don't compile due to conflicting types, e.g.
include both <stdint.h> and <sys/sysctl.h> in one source file.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug libc/14809] glibc's sysctl.h thinks it knows the <linux/kernel.h> feature test macro
2012-11-05 20:30 [Bug libc/14809] New: glibc's sysctl.h thinks it knows the <linux/kernel.h> feature test macro kkeithle at redhat dot com
@ 2012-11-05 20:33 ` kkeithle at redhat dot com
2012-11-05 20:36 ` [Bug libc/14809] glibc's sysctl.h uses incorrect <linux/kernel.h> feature test macro starting with kernel-3.7.x kkeithle at redhat dot com
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: kkeithle at redhat dot com @ 2012-11-05 20:33 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=14809
kkeithle at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Host| |Fedora rawhide
See Also| |https://bugzilla.redhat.com
| |/show_bug.cgi?id=873397
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug libc/14809] glibc's sysctl.h uses incorrect <linux/kernel.h> feature test macro starting with kernel-3.7.x
2012-11-05 20:30 [Bug libc/14809] New: glibc's sysctl.h thinks it knows the <linux/kernel.h> feature test macro kkeithle at redhat dot com
2012-11-05 20:33 ` [Bug libc/14809] " kkeithle at redhat dot com
@ 2012-11-05 20:36 ` kkeithle at redhat dot com
2012-11-06 14:25 ` kkeithle at redhat dot com
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: kkeithle at redhat dot com @ 2012-11-05 20:36 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=14809
kkeithle at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|glibc's sysctl.h thinks it |glibc's sysctl.h uses
|knows the <linux/kernel.h> |incorrect <linux/kernel.h>
|feature test macro |feature test macro starting
| |with kernel-3.7.x
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug libc/14809] glibc's sysctl.h uses incorrect <linux/kernel.h> feature test macro starting with kernel-3.7.x
2012-11-05 20:30 [Bug libc/14809] New: glibc's sysctl.h thinks it knows the <linux/kernel.h> feature test macro kkeithle at redhat dot com
2012-11-05 20:33 ` [Bug libc/14809] " kkeithle at redhat dot com
2012-11-05 20:36 ` [Bug libc/14809] glibc's sysctl.h uses incorrect <linux/kernel.h> feature test macro starting with kernel-3.7.x kkeithle at redhat dot com
@ 2012-11-06 14:25 ` kkeithle at redhat dot com
2012-11-06 14:33 ` [Bug libc/14809] glibc's sysctl.h uses incorrect <linux/kernel.h> header guard " kkeithle at redhat dot com
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: kkeithle at redhat dot com @ 2012-11-06 14:25 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=14809
--- Comment #1 from kkeithle at redhat dot com 2012-11-06 14:25:21 UTC ---
s/feature test/header guard/
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug libc/14809] glibc's sysctl.h uses incorrect <linux/kernel.h> header guard macro starting with kernel-3.7.x
2012-11-05 20:30 [Bug libc/14809] New: glibc's sysctl.h thinks it knows the <linux/kernel.h> feature test macro kkeithle at redhat dot com
` (2 preceding siblings ...)
2012-11-06 14:25 ` kkeithle at redhat dot com
@ 2012-11-06 14:33 ` kkeithle at redhat dot com
2012-11-07 8:48 ` aj at suse dot de
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: kkeithle at redhat dot com @ 2012-11-06 14:33 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=14809
kkeithle at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|glibc's sysctl.h uses |glibc's sysctl.h uses
|incorrect <linux/kernel.h> |incorrect <linux/kernel.h>
|feature test macro starting |header guard macro starting
|with kernel-3.7.x |with kernel-3.7.x
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug libc/14809] glibc's sysctl.h uses incorrect <linux/kernel.h> header guard macro starting with kernel-3.7.x
2012-11-05 20:30 [Bug libc/14809] New: glibc's sysctl.h thinks it knows the <linux/kernel.h> feature test macro kkeithle at redhat dot com
` (3 preceding siblings ...)
2012-11-06 14:33 ` [Bug libc/14809] glibc's sysctl.h uses incorrect <linux/kernel.h> header guard " kkeithle at redhat dot com
@ 2012-11-07 8:48 ` aj at suse dot de
2012-11-07 20:43 ` aj at suse dot de
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: aj at suse dot de @ 2012-11-07 8:48 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=14809
Andreas Jaeger <aj at suse dot de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |aj at suse dot de
AssignedTo|unassigned at sourceware |aj at suse dot de
|dot org |
--- Comment #2 from Andreas Jaeger <aj at suse dot de> 2012-11-07 08:48:08 UTC ---
Thanks for the bug report, patch posted at:
http://sourceware.org/ml/libc-alpha/2012-11/msg00239.html
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug libc/14809] glibc's sysctl.h uses incorrect <linux/kernel.h> header guard macro starting with kernel-3.7.x
2012-11-05 20:30 [Bug libc/14809] New: glibc's sysctl.h thinks it knows the <linux/kernel.h> feature test macro kkeithle at redhat dot com
` (4 preceding siblings ...)
2012-11-07 8:48 ` aj at suse dot de
@ 2012-11-07 20:43 ` aj at suse dot de
2012-11-13 0:15 ` carlos_odonell at mentor dot com
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: aj at suse dot de @ 2012-11-07 20:43 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=14809
--- Comment #3 from Andreas Jaeger <aj at suse dot de> 2012-11-07 20:43:42 UTC ---
Fixed for head, will submit later for glibc 2.16/2.15 (after approval by
Carlos)
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug libc/14809] glibc's sysctl.h uses incorrect <linux/kernel.h> header guard macro starting with kernel-3.7.x
2012-11-05 20:30 [Bug libc/14809] New: glibc's sysctl.h thinks it knows the <linux/kernel.h> feature test macro kkeithle at redhat dot com
` (5 preceding siblings ...)
2012-11-07 20:43 ` aj at suse dot de
@ 2012-11-13 0:15 ` carlos_odonell at mentor dot com
2012-11-13 8:06 ` aj at suse dot de
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: carlos_odonell at mentor dot com @ 2012-11-13 0:15 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=14809
Carlos O'Donell <carlos_odonell at mentor dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |carlos_odonell at mentor
| |dot com
--- Comment #4 from Carlos O'Donell <carlos_odonell at mentor dot com> 2012-11-13 00:14:52 UTC ---
OK for 2.16/2.15.
Slightly off-topic: I didn't know we had to manually maintain those header
guards to prevent other headers from being included when we include the kernel
version. Do we really need to maintain this? Is this simply an optimization to
reduce the amount of cpp work that is done for this header?
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug libc/14809] glibc's sysctl.h uses incorrect <linux/kernel.h> header guard macro starting with kernel-3.7.x
2012-11-05 20:30 [Bug libc/14809] New: glibc's sysctl.h thinks it knows the <linux/kernel.h> feature test macro kkeithle at redhat dot com
` (6 preceding siblings ...)
2012-11-13 0:15 ` carlos_odonell at mentor dot com
@ 2012-11-13 8:06 ` aj at suse dot de
2012-11-27 14:17 ` schwab@linux-m68k.org
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: aj at suse dot de @ 2012-11-13 8:06 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=14809
Andreas Jaeger <aj at suse dot de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |glibc_2.15, glibc_2.16
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #5 from Andreas Jaeger <aj at suse dot de> 2012-11-13 08:06:11 UTC ---
Carlos, see the original comment: We get types declared twice.
I'm pushing this now to 2.16 and 2.15 branches.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug libc/14809] glibc's sysctl.h uses incorrect <linux/kernel.h> header guard macro starting with kernel-3.7.x
2012-11-05 20:30 [Bug libc/14809] New: glibc's sysctl.h thinks it knows the <linux/kernel.h> feature test macro kkeithle at redhat dot com
` (7 preceding siblings ...)
2012-11-13 8:06 ` aj at suse dot de
@ 2012-11-27 14:17 ` schwab@linux-m68k.org
2012-11-28 15:43 ` schwab@linux-m68k.org
2014-06-14 11:13 ` fweimer at redhat dot com
10 siblings, 0 replies; 12+ messages in thread
From: schwab@linux-m68k.org @ 2012-11-27 14:17 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=14809
--- Comment #6 from Andreas Schwab <schwab@linux-m68k.org> 2012-11-27 14:17:23 UTC ---
The kernel has been fixed, so this is no longer needed. No released kernel
will have this issue.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug libc/14809] glibc's sysctl.h uses incorrect <linux/kernel.h> header guard macro starting with kernel-3.7.x
2012-11-05 20:30 [Bug libc/14809] New: glibc's sysctl.h thinks it knows the <linux/kernel.h> feature test macro kkeithle at redhat dot com
` (8 preceding siblings ...)
2012-11-27 14:17 ` schwab@linux-m68k.org
@ 2012-11-28 15:43 ` schwab@linux-m68k.org
2014-06-14 11:13 ` fweimer at redhat dot com
10 siblings, 0 replies; 12+ messages in thread
From: schwab@linux-m68k.org @ 2012-11-28 15:43 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=14809
Andreas Schwab <schwab@linux-m68k.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |INVALID
--- Comment #7 from Andreas Schwab <schwab@linux-m68k.org> 2012-11-28 15:43:40 UTC ---
The patch has been reverted since it was a kernel bug.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug libc/14809] glibc's sysctl.h uses incorrect <linux/kernel.h> header guard macro starting with kernel-3.7.x
2012-11-05 20:30 [Bug libc/14809] New: glibc's sysctl.h thinks it knows the <linux/kernel.h> feature test macro kkeithle at redhat dot com
` (9 preceding siblings ...)
2012-11-28 15:43 ` schwab@linux-m68k.org
@ 2014-06-14 11:13 ` fweimer at redhat dot com
10 siblings, 0 replies; 12+ messages in thread
From: fweimer at redhat dot com @ 2014-06-14 11:13 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=14809
Florian Weimer <fweimer at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |security-
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2014-06-14 11:13 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-05 20:30 [Bug libc/14809] New: glibc's sysctl.h thinks it knows the <linux/kernel.h> feature test macro kkeithle at redhat dot com
2012-11-05 20:33 ` [Bug libc/14809] " kkeithle at redhat dot com
2012-11-05 20:36 ` [Bug libc/14809] glibc's sysctl.h uses incorrect <linux/kernel.h> feature test macro starting with kernel-3.7.x kkeithle at redhat dot com
2012-11-06 14:25 ` kkeithle at redhat dot com
2012-11-06 14:33 ` [Bug libc/14809] glibc's sysctl.h uses incorrect <linux/kernel.h> header guard " kkeithle at redhat dot com
2012-11-07 8:48 ` aj at suse dot de
2012-11-07 20:43 ` aj at suse dot de
2012-11-13 0:15 ` carlos_odonell at mentor dot com
2012-11-13 8:06 ` aj at suse dot de
2012-11-27 14:17 ` schwab@linux-m68k.org
2012-11-28 15:43 ` schwab@linux-m68k.org
2014-06-14 11:13 ` fweimer at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).