[Bug build/14995] New: glibc fails to build if gold is the default linker, even if ld.bfd is available

[Bug build/14995] New: glibc fails to build if gold is the default linker, even if ld.bfd is available

[Bernhard.Rosenkranzer at linaro dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14995

             Bug #: 14995
           Summary: glibc fails to build if gold is the default linker,
                    even if ld.bfd is available
           Product: glibc
           Version: 2.17
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
        AssignedTo: unassigned@sourceware.org
        ReportedBy: Bernhard.Rosenkranzer@linaro.org
                CC: carlos@systemhalted.org
    Classification: Unclassified


If gold is the default linker, but ld.bfd is available (binutils compiled with
--enable-ld --enable-gold=default), glibc configure fails:


checking version of
/usr/lib/gcc/armv7hl-mandriva-linux-gnueabi/4.7.3/../../../../armv7hl-mandriva-linux-gnueabi/bin/ld...
v. ?.??, bad
[...]
configure: error: 
*** These critical programs are missing or too old: ld
*** Check the INSTALL file for required versions.


If the configure script doesn't find a version of "ld" it can use, it should
check for "ld.bfd" in the same location.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug build/14995] glibc fails to build if gold is the default linker, even if ld.bfd is available

[carlos at systemhalted dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14995

--- Comment #1 from Carlos O'Donell <carlos at systemhalted dot org> 2013-01-04 20:31:39 UTC ---
Created attachment 6795
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6795
Support falling back to ld.bfd if compiler suggested linker is gold.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug build/14995] glibc fails to build if gold is the default linker, even if ld.bfd is available

[carlos at systemhalted dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14995

Carlos O'Donell <carlos at systemhalted dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING
         AssignedTo|unassigned at sourceware    |carlos at systemhalted dot
                   |dot org                     |org

--- Comment #2 from Carlos O'Donell <carlos at systemhalted dot org> 2013-01-04 20:33:30 UTC ---
Bernhard,

Could you please apply the attached patch, run `autoconf' from the top-level
glibc src directory, and then try to build again?

Please provide your config.log.

Could you also run the testsuite e.g. make -k check >& check.log, and attach
the check.log (I'm curious to see what results you get).

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug build/14995] glibc fails to build if gold is the default linker, even if ld.bfd is available

[law at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14995

law at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |law at redhat dot com

--- Comment #3 from law at redhat dot com 2013-01-04 20:38:08 UTC ---
Carlos, I've wanted a patch like that for a few years.

It fell off the radar for a while, but at some point I'd like to see Fedora
flip to gold as the default linker and packages such as glibc which depend on
things like editing the default linker script (which can't and won't ever work
with gold) need to fallback gracefully.

Thanks!

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug build/14995] glibc fails to build if gold is the default linker, even if ld.bfd is available

[carlos at systemhalted dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14995

Carlos O'Donell <carlos at systemhalted dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6795|0                           |1
        is obsolete|                            |

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug build/14995] glibc fails to build if gold is the default linker, even if ld.bfd is available

[carlos at systemhalted dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14995

--- Comment #4 from Carlos O'Donell <carlos at systemhalted dot org> 2013-01-09 04:20:11 UTC ---
Created attachment 6804
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6804
Support building glibc with gold 1.11 or newer.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug build/14995] glibc fails to build if gold is the default linker, even if ld.bfd is available

[carlos at systemhalted dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14995

--- Comment #5 from Carlos O'Donell <carlos at systemhalted dot org> 2013-01-09 04:22:46 UTC ---
OK, my previous patch does nothing, the only way to fix this properly would be
a spec file that overrides the compiler driver behaviour and uses ld.bfd. 

However, after some experimentation the truth is that gold *can* be used to
build glibc, and I see only 7 regressions on x86_64.

Therefore the approach I'm going to take is: You set gold as the default
linker, and we're going to support gold 1.11 and newer. 

You'll need to fix gold, the testsuite or the implementation to pass those 7
regressions. Building and using glibc built by gold is subject to testsuite
results.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug build/14995] glibc fails to build if gold is the default linker, even if ld.bfd is available

[carlos at systemhalted dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14995

--- Comment #6 from Carlos O'Donell <carlos at systemhalted dot org> 2013-01-10 19:11:11 UTC ---
Upstream consensus is that we should really fix the regressions with gold
before enabling it fully.

This issue won't be easily fixed until:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55470
becomes more widely available or backported to more branches.

Then we can check for support of -fuse-ld, and then pass -fuse-ld=bfd to enable
the use of ld.bfd for all compilations.

Discussing this upstream on libc-alpha right now.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug build/14995] glibc fails to build if gold is the default linker, even if ld.bfd is available

[neleai at seznam dot cz]

https://sourceware.org/bugzilla/show_bug.cgi?id=14995

Ondrej Bilka <neleai at seznam dot cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |neleai at seznam dot cz

--- Comment #7 from Ondrej Bilka <neleai at seznam dot cz> ---
Carlos, it was 9 months so gcc side should be resolved and we could return to
fixing failures.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/14995] glibc fails to build if gold is the default linker, even if ld.bfd is available

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14995

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|carlos at redhat dot com           |unassigned at sourceware dot org

--- Comment #8 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to Ondrej Bilka from comment #7)
> Carlos, it was 9 months so gcc side should be resolved and we could return
> to fixing failures.

I'm not currently working on this so I'm going to unassign myself. The status
remains the same, but now with -fuse-ld or -fuse-gold things should be much
easier to test and fix. The testsuite regressions still need to be understood
before this gets enabled.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/14995] glibc fails to build if gold is the default linker, even if ld.bfd is available

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14995

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/14995] glibc fails to build if gold is the default linker, even if ld.bfd is available

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14995

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
            Version|2.17                        |2.21
           Assignee|unassigned at sourceware dot org   |hjl.tools at gmail dot com
   Target Milestone|---                         |2.22

--- Comment #9 from H.J. Lu <hjl.tools at gmail dot com> ---
It isn't impossible to build glibc with gold. But at lease we
should use -fuse-ld=bfd to build shared libraries and use gold
for test.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/14995] glibc fails to build if gold is the default linker, even if ld.bfd is available

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14995

--- Comment #10 from H.J. Lu <hjl.tools at gmail dot com> ---
Gold can create glibc share libraries. but with incorrect
versioned symbols.  Some symbols in libc.so, like_res@GLIBC_2.2.5,
are deprecated.  Those symbols have @GLIBC_X.Y.Z suffixes.
But gold 1.11 (20150309) generates:

_res@@GLIBC_2.2.5
__ctype32_b@@GLIBC_2.2.5
__ctype32_tolower@@GLIBC_2.2.5
__ctype32_toupper@@GLIBC_2.2.5
__ctype_b@@GLIBC_2.2.5
__ctype_tolower@@GLIBC_2.2.5
__ctype_toupper@@GLIBC_2.2.5

instead of

_res@GLIBC_2.2.5
__ctype32_b@GLIBC_2.2.5
__ctype32_tolower@GLIBC_2.2.5
__ctype32_toupper@GLIBC_2.2.5
__ctype_b@GLIBC_2.2.5
__ctype_tolower@GLIBC_2.2.5
__ctype_toupper@GLIBC_2.2.5

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/14995] glibc fails to build if gold is the default linker, even if ld.bfd is available

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=14995

--- Comment #11 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, hjl/pr14995 has been created
        at  0eb345cb8844391881de0a53c6ad36917bbf4453 (commit)

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=0eb345cb8844391881de0a53c6ad36917bbf4453

commit 0eb345cb8844391881de0a53c6ad36917bbf4453
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Mon Mar 9 09:16:26 2015 -0700

    Support build glibc with gold as default linker

    The gold linker has no builtin default linker script and it can't be
    to create shared libraries.  Unless --enable-gold is used, it should
    only be used to create executables.  Use -fuse-ld=bfd to create shared
    libraries.

        [BZ #14995]
        * Makerules (shlib-LDFLAGS): New.
        ($(common-objpfx)shlib.lds): Use it.
        (build-shlib): Likewise.
        (build-module-helper): Likewise.
        ($(common-objpfx)libc_pic.os): Likewise.
        * config.make.in (use-bfd): New.
        * configure: Regenerated.
        * configure.ac: Add --enable-gold.
        Accept gold 1.11 or higher.
        (libc_cv_cc_use_bfd): Set to yes if -fuse-ld=bfd works.  AC_SUBST.
        (LDBFDFLAGS): New.
        Use $LDBFDFLAGS to check if default -shared layout is sufficient.

-----------------------------------------------------------------------

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/14995] glibc fails to build if gold is the default linker, even if ld.bfd is available

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14995

--- Comment #12 from H.J. Lu <hjl.tools at gmail dot com> ---
A patch is posted at

https://sourceware.org/ml/libc-alpha/2015-03/msg00410.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/14995] glibc fails to build if gold is the default linker, even if ld.bfd is available

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=14995

--- Comment #13 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, hjl/pr14995 has been created
        at  389ed28d1175b67ee5dcd40e69df912d4a1109b0 (commit)

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=389ed28d1175b67ee5dcd40e69df912d4a1109b0

commit 389ed28d1175b67ee5dcd40e69df912d4a1109b0
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Mon Mar 9 09:16:26 2015 -0700

    Support build glibc with gold as default linker

    The gold linker has no builtin default linker script and it can't be
    to create shared libraries.  Unless --enable-gold is used, it should
    only be used to create executables.  Use -fuse-ld=bfd to create shared
    libraries.

        [BZ #14995]
        * Makerules (shlib-LDFLAGS): New.
        ($(common-objpfx)shlib.lds): Use it.
        (build-shlib): Likewise.
        (build-module-helper): Likewise.
        ($(common-objpfx)libc_pic.os): Likewise.
        * config.make.in (use-bfd): New.
        * configure: Regenerated.
        * configure.ac: Add --enable-gold.
        Accept gold 1.11 or higher.
        (libc_cv_cc_use_bfd): Set to yes if -fuse-ld=bfd works.  AC_SUBST.
        (LDBFDFLAGS): New.
        Use $LDBFDFLAGS to check if default -shared layout is sufficient.

-----------------------------------------------------------------------

-- 
You are receiving this mail because:
You are on the CC list for the bug.