[Bug libc/15132] New: stat/fstat called unnecessarily for statvfs/fstatvfs

[Bug libc/15132] New: stat/fstat called unnecessarily for statvfs/fstatvfs

[normalperson at yhbt dot net]

http://sourceware.org/bugzilla/show_bug.cgi?id=15132

             Bug #: 15132
           Summary: stat/fstat called unnecessarily for statvfs/fstatvfs
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: minor
          Priority: P2
         Component: libc
        AssignedTo: unassigned@sourceware.org
        ReportedBy: normalperson@yhbt.net
                CC: drepper.fsp@gmail.com
    Classification: Unclassified


statvfs/fstatvfs call stat/fstat unnecessarily when the Linux kernel (2.6.36+)
returns ST_VALID in statfs/fstatfs.  The stat/fstat are unnecessary syscalls
which can be avoided.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/15132] stat/fstat called unnecessarily for statvfs/fstatvfs

[normalperson at yhbt dot net]

http://sourceware.org/bugzilla/show_bug.cgi?id=15132

--- Comment #1 from Eric Wong <normalperson at yhbt dot net> 2013-02-10 23:03:32 UTC ---
Created attachment 6861
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6861
[PATCH] avoid stat/fstat in statvfs/fstatvfs

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/15132] stat/fstat called unnecessarily for statvfs/fstatvfs

[ondra at iuuk dot mff.cuni.cz]

http://sourceware.org/bugzilla/show_bug.cgi?id=15132

OndrejBilka <ondra at iuuk dot mff.cuni.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ondra at iuuk dot mff.cuni.cz

--- Comment #2 from OndrejBilka <ondra at iuuk dot mff.cuni.cz> ---
Looks ok for me. Could you post it to libc-alpha?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Re: [Bug libc/15132] stat/fstat called unnecessarily for statvfs/fstatvfs

[Ondřej Bílka]

On Wed, Jun 12, 2013 at 12:19:08AM +0000, normalperson at yhbt dot net wrote:
> http://sourceware.org/bugzilla/show_bug.cgi?id=15132
> 
> --- Comment #3 from Eric Wong <normalperson at yhbt dot net> ---
> I already posted this to libc-alpha before creating this BZ entry.
> Apparently I need copyright assignment papers, but I'm unsure which ones...
> 
> ref: http://mid.gmane.org/20130211003736.GA12979@dcvr.yhbt.net
>
See following page, As completing them takes a while it is better to
also mention other projects you will likely contribute in advance.

http://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-assign.future 

[Bug libc/15132] stat/fstat called unnecessarily for statvfs/fstatvfs

[neleai at seznam dot cz]

http://sourceware.org/bugzilla/show_bug.cgi?id=15132

--- Comment #4 from Ondrej Bilka <neleai at seznam dot cz> ---
On Wed, Jun 12, 2013 at 12:19:08AM +0000, normalperson at yhbt dot net wrote:
> http://sourceware.org/bugzilla/show_bug.cgi?id=15132
> 
> --- Comment #3 from Eric Wong <normalperson at yhbt dot net> ---
> I already posted this to libc-alpha before creating this BZ entry.
> Apparently I need copyright assignment papers, but I'm unsure which ones...
> 
> ref: http://mid.gmane.org/20130211003736.GA12979@dcvr.yhbt.net
>
See following page, As completing them takes a while it is better to
also mention other projects you will likely contribute in advance.

http://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-assign.future

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/15132] stat/fstat called unnecessarily for statvfs/fstatvfs

[neleai at seznam dot cz]

https://sourceware.org/bugzilla/show_bug.cgi?id=15132

Ondrej Bilka <neleai at seznam dot cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING
                 CC|                            |neleai at seznam dot cz

--- Comment #5 from Ondrej Bilka <neleai at seznam dot cz> ---
Did assignment papers arrived?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/15132] stat/fstat called unnecessarily for statvfs/fstatvfs

[normalperson at yhbt dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=15132

--- Comment #6 from Eric Wong <normalperson at yhbt dot net> ---
I should have my copyright assignment paperwork in order, gnu.org RT #862506

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/15132] stat/fstat called unnecessarily for statvfs/fstatvfs

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=15132

--- Comment #7 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  26b0d2e1a1606da10c4dc4e109d7b9f2d92aab6a (commit)
      from  0d3b7a190c3abbdce27d4b0b9f16517bf5664099 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=26b0d2e1a1606da10c4dc4e109d7b9f2d92aab6a

commit 26b0d2e1a1606da10c4dc4e109d7b9f2d92aab6a
Author: Eric Wong <normalperson@yhbt.net>
Date:   Thu May 29 09:41:29 2014 +0530

    Avoid stat/fstat in statvfs/fstatvfs (BZ #15132)

    Delay the use of stat/fstat until stat data is required.  When the
    kernel returns ST_VALID, stat data is not used by __internal_statvfs.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                  |   16 ++++++++++++++++
 NEWS                                       |   20 ++++++++++----------
 sysdeps/unix/sysv/linux/fstatvfs.c         |    4 ++--
 sysdeps/unix/sysv/linux/fstatvfs64.c       |   10 +++-------
 sysdeps/unix/sysv/linux/internal_statvfs.c |   15 ++++++++-------
 sysdeps/unix/sysv/linux/statvfs.c          |    6 ++----
 sysdeps/unix/sysv/linux/statvfs64.c        |   10 +++-------
 7 files changed, 44 insertions(+), 37 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/15132] stat/fstat called unnecessarily for statvfs/fstatvfs

[siddhesh at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15132

Siddhesh Poyarekar <siddhesh at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
                 CC|                            |siddhesh at redhat dot com
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/15132] stat/fstat called unnecessarily for statvfs/fstatvfs

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15132

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.