[Bug dynamic-link/15309] New: dl_open_worker doesn't fully initialize seen array during init sort

[Bug dynamic-link/15309] New: dl_open_worker doesn't fully initialize seen array during init sort

[dhatch at ilm dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15309

             Bug #: 15309
           Summary: dl_open_worker doesn't fully initialize seen array
                    during init sort
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: dynamic-link
        AssignedTo: unassigned@sourceware.org
        ReportedBy: dhatch@ilm.com
    Classification: Unclassified


In elf/dl-open.c, in dl_open_worker(), the "seen" array was recently changed
from a char[] to uint16_t[], but the initialization wasn't changed to match:
    28363bbf (Jeff Law           2012-06-21 09:26:41 -0600 346)       uint16_t
seen[nmaps];
    6ee65ed6 (Ulrich Drepper     2012-01-27 15:05:19 -0500 347)       memset
(seen, '\0', nmaps);
It should be: 
    memset (seen, '\0', nmaps * sizeof(seen[0]));

Theoretically this could cause some loops in this sorting routine
to terminate prematurely, resulting in an incorrect sort.
Not sure whether this ever happens in practice.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug dynamic-link/15309] dl_open_worker doesn't fully initialize seen array during init sort

[dhatch at ilm dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15309

Don Hatch <dhatch at ilm dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |law at redhat dot com

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug dynamic-link/15309] dl_open_worker doesn't fully initialize seen array during init sort

[carlos at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15309

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |carlos at redhat dot com

--- Comment #1 from Carlos O'Donell <carlos at redhat dot com> 2013-03-27 13:16:39 UTC ---
I'm fixing this.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug dynamic-link/15309] dl_open_worker doesn't fully initialize seen array during init sort

[dhatch at ilm dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15309

Don Hatch <dhatch at ilm dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |15310

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug dynamic-link/15309] dl_open_worker doesn't fully initialize seen array during init sort

[dhatch at ilm dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15309

--- Comment #2 from Don Hatch <dhatch at ilm dot com> 2013-03-28 10:23:22 UTC ---
declared this to be blocking bug 15310 -- see note I added there for
explanation.
it would be good to get this 1-line fix into master pretty quick if possible.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug dynamic-link/15309] dl_open_worker doesn't fully initialize seen array during init sort

[carlos at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15309

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Carlos O'Donell <carlos at redhat dot com> 2013-04-06 21:07:34 UTC ---
Fixed by this commit.

commit 7208a313b93a42e3cef61c4249a59b4b32a5850b
Author: Carlos O'Donell <carlos@redhat.com>
Date:   Sat Apr 6 17:00:02 2013 -0400

    dl_open_worker: Memset all of seen array.

    The seen array was doubled in size recently, but the memset to clear
    the array was not adjusted. We adjust the memset to always be correct
    regardless of the size of seen.

    ---

    2013-04-06  Carlos O'Donell  <carlos@redhat.com>

        [BZ #15309]
        * elf/dl-open.c (dl_open_worker): memset all of seen array.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug dynamic-link/15309] dl_open_worker doesn't fully initialize seen array during init sort

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15309

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dynamic-link/15309] dl_open_worker doesn't fully initialize seen array during init sort

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15309

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.