From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18319 invoked by alias); 2 Apr 2013 23:37:43 -0000 Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: glibc-bugs-owner@sourceware.org Received: (qmail 18252 invoked by uid 48); 2 Apr 2013 23:37:35 -0000 From: "dhatch at ilm dot com" To: glibc-bugs@sourceware.org Subject: [Bug dynamic-link/15310] _dl_sort_fini is O(n^3) causing slow exit when many dsos Date: Tue, 02 Apr 2013 23:37:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: dynamic-link X-Bugzilla-Keywords: X-Bugzilla-Severity: critical X-Bugzilla-Who: dhatch at ilm dot com X-Bugzilla-Status: WAITING X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Attachment #6955 is obsolete Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 X-SW-Source: 2013-04/txt/msg00013.txt.bz2 http://sourceware.org/bugzilla/show_bug.cgi?id=15310 Don Hatch changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6955|0 |1 is obsolete| | --- Comment #18 from Don Hatch 2013-04-02 23:37:34 UTC --- Created attachment 6965 --> http://sourceware.org/bugzilla/attachment.cgi?id=6965 Proposed initial patch, rearranging init/fini sorting in prep for overhaul. diffs from master at 60c414c Tweaked the proposed initial refactoring patch a bit to make the calling convention cleaner: consistently let the sort functions handle too-small inputs in whatever way they need to, rather than haphazardly having the caller do it sometimes. This makes for a cleaner contract so callers and unit test can be simpler and less error prone. (found this when unit testing _dl_sort_init on a list of length 0, and it crashed) -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.