public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dhatch at ilm dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug dynamic-link/15311] _dl_sort_fini static deps can be violated by dynamic ones
Date: Thu, 28 Mar 2013 05:00:00 -0000 [thread overview]
Message-ID: <bug-15311-131-vQ6lBgMO3g@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-15311-131@http.sourceware.org/bugzilla/>
http://sourceware.org/bugzilla/show_bug.cgi?id=15311
--- Comment #6 from Don Hatch <dhatch at ilm dot com> 2013-03-28 05:00:18 UTC ---
(In reply to comment #3)
> If you do topologic sort it should suffice to take static dependency
> edges before dynamic ones, it assures that static when static are acyclic then
> they are always correctly ordered.
Hi Ondrej,
I'm sorry, I just realized that in my previous reply to this comment of yours,
I outlined my strategy without actually addressing your simpler proposal at
all.
I don't think what you are suggesting will work.
If I'm reading it correctly, you're saying that, when iterating through
the successors of a given node, consider static successors first
and dynamic onces after that.
Here is an example where that doesn't work:
Static dependencies: A->B->C->D->E
Dynamic dependencies: E->A
In this case each node has exactly one successor (static or dynamic),
so the order in which successors are considered clearly makes no difference.
If the depth-first-search happens to start at C,
it will produce the output (reverse postordering): C D E A B.
The correct answer is A B C D E.
My strategy works properly on this example (of course :-)):
first pass (topsort static+dynamic) produces arbitrary output,
since it's all one big SCC;
second pass (topsort static only) produces correct order A B C D E.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
next prev parent reply other threads:[~2013-03-28 5:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 7:49 [Bug dynamic-link/15311] New: " dhatch at ilm dot com
2013-03-27 8:46 ` [Bug dynamic-link/15311] " dhatch at ilm dot com
2013-03-27 12:59 ` carlos at redhat dot com
2013-03-27 20:35 ` dhatch at ilm dot com
2013-03-27 22:09 ` [Bug dynamic-link/15311] New: " Ondřej Bílka
2013-03-27 22:09 ` [Bug dynamic-link/15311] " neleai at seznam dot cz
2013-03-27 22:40 ` dhatch at ilm dot com
2013-03-28 4:36 ` dhatch at ilm dot com
2013-03-28 5:00 ` dhatch at ilm dot com [this message]
2013-03-28 7:37 ` Ondřej Bílka
2013-03-28 7:37 ` neleai at seznam dot cz
2013-03-28 8:19 ` Ondřej Bílka
2013-03-28 8:19 ` neleai at seznam dot cz
2013-03-29 14:53 ` dhatch at ilm dot com
2014-06-13 18:36 ` fweimer at redhat dot com
2021-10-21 19:21 ` cvs-commit at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-15311-131-vQ6lBgMO3g@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=glibc-bugs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).