public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug network/15347] New: __FD_MASK triggers undefined behavior
@ 2013-04-08 13:59 fweimer at redhat dot com
  2013-04-15  9:09 ` [Bug libc/15347] " siddhesh at redhat dot com
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: fweimer at redhat dot com @ 2013-04-08 13:59 UTC (permalink / raw)
  To: glibc-bugs

http://sourceware.org/bugzilla/show_bug.cgi?id=15347

             Bug #: 15347
           Summary: __FD_MASK triggers undefined behavior
           Product: glibc
           Version: 2.17
            Status: NEW
          Severity: normal
          Priority: P2
         Component: network
        AssignedTo: fweimer@redhat.com
        ReportedBy: fweimer@redhat.com
    Classification: Unclassified


typedef long int __fd_mask;
#define __FD_MASK(d)    ((__fd_mask) 1 << ((d) % __NFDBITS))

1 can be shifted into the sign position, which isn't legal C.

I think we should just use 1UL and cast the result of the shift.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Bug libc/15347] __FD_MASK triggers undefined behavior
  2013-04-08 13:59 [Bug network/15347] New: __FD_MASK triggers undefined behavior fweimer at redhat dot com
@ 2013-04-15  9:09 ` siddhesh at redhat dot com
  2014-02-26  9:13 ` fweimer at redhat dot com
  2014-06-13 18:28 ` fweimer at redhat dot com
  2 siblings, 0 replies; 4+ messages in thread
From: siddhesh at redhat dot com @ 2013-04-15  9:09 UTC (permalink / raw)
  To: glibc-bugs

http://sourceware.org/bugzilla/show_bug.cgi?id=15347

Siddhesh Poyarekar <siddhesh at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drepper.fsp at gmail dot
                   |                            |com
          Component|network                     |libc

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Bug libc/15347] __FD_MASK triggers undefined behavior
  2013-04-08 13:59 [Bug network/15347] New: __FD_MASK triggers undefined behavior fweimer at redhat dot com
  2013-04-15  9:09 ` [Bug libc/15347] " siddhesh at redhat dot com
@ 2014-02-26  9:13 ` fweimer at redhat dot com
  2014-06-13 18:28 ` fweimer at redhat dot com
  2 siblings, 0 replies; 4+ messages in thread
From: fweimer at redhat dot com @ 2014-02-26  9:13 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=15347

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
            Version|2.17                        |2.19
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.20

--- Comment #1 from Florian Weimer <fweimer at redhat dot com> ---
Fixed in commit 4cbf380ce948ca15a965a78f0c1a092cf5956792.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Bug libc/15347] __FD_MASK triggers undefined behavior
  2013-04-08 13:59 [Bug network/15347] New: __FD_MASK triggers undefined behavior fweimer at redhat dot com
  2013-04-15  9:09 ` [Bug libc/15347] " siddhesh at redhat dot com
  2014-02-26  9:13 ` fweimer at redhat dot com
@ 2014-06-13 18:28 ` fweimer at redhat dot com
  2 siblings, 0 replies; 4+ messages in thread
From: fweimer at redhat dot com @ 2014-06-13 18:28 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=15347

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-06-13 18:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-08 13:59 [Bug network/15347] New: __FD_MASK triggers undefined behavior fweimer at redhat dot com
2013-04-15  9:09 ` [Bug libc/15347] " siddhesh at redhat dot com
2014-02-26  9:13 ` fweimer at redhat dot com
2014-06-13 18:28 ` fweimer at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).