[Bug math/15467] New: sincos does not set errno on domain error

[Bug math/15467] New: sincos does not set errno on domain error

[jsm28 at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=15467

             Bug #: 15467
           Summary: sincos does not set errno on domain error
           Product: glibc
           Version: 2.17
            Status: NEW
          Severity: normal
          Priority: P2
         Component: math
        AssignedTo: unassigned@sourceware.org
        ReportedBy: jsm28@gcc.gnu.org
    Classification: Unclassified


When positive or negative infinity is passed to sincos, this is a domain error
and should set errno to EDOM just as it does for sin or cos individually.  But
for the double version of sincos on x86_64, it doesn't set errno in this case.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug math/15467] sincos does not set errno on domain error

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15467

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/15467] sincos does not set errno on domain error

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=15467

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  d435569cd626bccb9c27361202a279d0fd7fce88 (commit)
      from  ef0ffcfd13fea7544c2d83d222963b0da4963734 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d435569cd626bccb9c27361202a279d0fd7fce88

commit d435569cd626bccb9c27361202a279d0fd7fce88
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Feb 11 23:17:25 2015 +0000

    Fix sincos errno setting (bug 15467).

    This patch makes sincos set errno to EDOM when passed an infinity,
    similarly to sin and cos.

    Tested for x86_64, x86, powerpc and mips64.  I don't know if the
    architecture-specific implementations for ia64 and m68k might need
    corresponding fixes.

    2015-02-11  Joseph Myers  <joseph@codesourcery.com>

        [BZ #15467]
        * sysdeps/ieee754/dbl-64/s_sincos.c: Include <errno.h>.
        (__sincos): Set errno to EDOM for infinite argument.
        * sysdeps/ieee754/flt-32/s_sincosf.c: Include <errno.h>.
        (SINCOSF_FUNC): Set errno to EDOM for infinite argument.
        * sysdeps/ieee754/ldbl-128/s_sincosl.c: Include <errno.h>.
        (__sincosl): Set errno to EDOM for infinite argument.
        * sysdeps/ieee754/ldbl-128ibm/s_sincosl.c: Include <errno.h>.
        (__sincosl): Set errno to EDOM for infinite argument.
        * sysdeps/ieee754/ldbl-96/s_sincosl.c: Include <errno.h>.
        (__sincosl): Set errno to EDOM for infinite argument.
        * math/libm-test.inc (sincos_test_data): Test errno setting.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                               |   15 +++++++++++++++
 NEWS                                    |    2 +-
 math/libm-test.inc                      |    6 +++---
 sysdeps/ieee754/dbl-64/s_sincos.c       |    3 +++
 sysdeps/ieee754/flt-32/s_sincosf.c      |    3 +++
 sysdeps/ieee754/ldbl-128/s_sincosl.c    |    3 +++
 sysdeps/ieee754/ldbl-128ibm/s_sincosl.c |    3 +++
 sysdeps/ieee754/ldbl-96/s_sincosl.c     |    3 +++
 8 files changed, 34 insertions(+), 4 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/15467] sincos does not set errno on domain error

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=15467

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.22.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/15467] sincos does not set errno on domain error

[mtk.manpages at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15467

Michael Kerrisk <mtk.manpages at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtk.manpages at gmail dot com

--- Comment #4 from Michael Kerrisk <mtk.manpages at gmail dot com> ---
Fix document in man-pages.


diff --git a/man3/sincos.3 b/man3/sincos.3
index b8c3089f8..c299d17b6 100644
--- a/man3/sincos.3
+++ b/man3/sincos.3
@@ -60,9 +60,10 @@ when calling these functions.
 The following errors can occur:
 .TP
 Domain error: \fIx\fP is an infinity
-.\" .I errno
-.\" is set to
-.\" .BR EDOM .
+.I errno
+is set to
+.BR EDOM
+(but see BUGS).
 An invalid floating-point exception
 .RB ( FE_INVALID )
 is raised.
@@ -103,6 +104,13 @@ built-in optimizations, using flags such as:
 cc -O \-lm \-fno\-builtin prog.c
 .EE
 .in
+.SH BUGS
+Before version 2.22, the glibc implementation did not set
+.\" https://www.sourceware.org/bugzilla/show_bug.cgi?id=15467
+.I errno
+to
+.B EDOM
+when a domain error occurred.
 .SH SEE ALSO
 .BR cos (3),
 .BR sin (3),

-- 
You are receiving this mail because:
You are on the CC list for the bug.