From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14504 invoked by alias); 22 Oct 2015 23:16:26 -0000 Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: glibc-bugs-owner@sourceware.org Received: (qmail 14430 invoked by uid 55); 22 Oct 2015 23:16:18 -0000 From: "cvs-commit at gcc dot gnu.org" To: glibc-bugs@sourceware.org Subject: [Bug math/15491] [i386/x86_64] x86 nearbyint implementations wrongly clear all exceptions Date: Thu, 22 Oct 2015 23:16:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: math X-Bugzilla-Version: 2.17 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: security- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-10/txt/msg00286.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=15491 --- Comment #1 from cvs-commit at gcc dot gnu.org --- This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GNU C Library master sources". The branch, master has been updated via 846d9a4a3acdb4939ca7bf6aed48f9f6f26911be (commit) from 45ccb8346bba9b0f7a72a92d7f8b1c796dd496ba (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=846d9a4a3acdb4939ca7bf6aed48f9f6f26911be commit 846d9a4a3acdb4939ca7bf6aed48f9f6f26911be Author: Joseph Myers Date: Thu Oct 22 23:14:55 2015 +0000 Fix i386 / x86_64 nearbyint exception clearing (bug 15491). The implementations of nearbyint functions using x87 floating point (i386 all versions, x86_64 long double only) use the fclex instruction, which clears any exceptions that were raised before the function was called. These functions must not clear exceptions that were raised before they were called. This patch fixes these functions to save and restore the whole floating-point environment (fnstenv / fldenv) as the way of avoiding raising "inexact" (recall that there isn't an x87 instruction for loading just the status word, so the whole environment has to be saved and loaded instead - the code already saved and loaded the control word, which is now obtained from the saved environment after this patch, to disable traps on "inexact"). In the case of the long double functions, any "invalid" exception from frndint (applied to a signaling NaN) needs merging into the saved state; this issue doesn't apply to the float and double functions because that exception would have been raised when the argument is loaded, before the environment is saved. [BZ #15491] * sysdeps/i386/fpu/s_nearbyint.S (__nearbyint): Save and restore floating-point environment instead of clearing all exceptions. * sysdeps/i386/fpu/s_nearbyintf.S (__nearbyintf): Likewise. * sysdeps/i386/fpu/s_nearbyintl.S (__nearbyintl): Likewise, merging in "invalid" exceptions from frndint. * sysdeps/x86_64/fpu/s_nearbyintl.S (__nearbyintl): Likewise. * math/test-nearbyint-except.c: New file. * math/Makefile (tests): Add test-nearbyint-except. ----------------------------------------------------------------------- Summary of changes: ChangeLog | 12 +++++ NEWS | 24 +++++----- math/Makefile | 2 +- math/test-nearbyint-except.c | 82 +++++++++++++++++++++++++++++++++++++ sysdeps/i386/fpu/s_nearbyint.S | 23 ++++------ sysdeps/i386/fpu/s_nearbyintf.S | 23 ++++------ sysdeps/i386/fpu/s_nearbyintl.S | 26 +++++------ sysdeps/x86_64/fpu/s_nearbyintl.S | 14 ++++--- 8 files changed, 145 insertions(+), 61 deletions(-) create mode 100644 math/test-nearbyint-except.c -- You are receiving this mail because: You are on the CC list for the bug.