[Bug libc/15539] New: nftw with FTW_HDIR doesn't restore cwd upon cancellation

[Bug libc/15539] New: nftw with FTW_HDIR doesn't restore cwd upon cancellation

[aoliva at sourceware dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=15539

            Bug ID: 15539
           Summary: nftw with FTW_HDIR doesn't restore cwd upon
                    cancellation
           Product: glibc
           Version: 2.18
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: aoliva at sourceware dot org
                CC: drepper.fsp at gmail dot com

Various resources can be leaked by ftw because it has no cleanup handler to
release allocated memory in case of thread cancellation.  Leaking memory and
file descriptors is unfortunate, but not always a show-stopper, but changing
the current working directory and not restoring it at the end feels a bit more
serious to me.  I'm not sure nftw is ever called with FTW_CHDIR in
multi-threaded programs, but I thought I'd report this issue so that it can be
discussed and, if found relevant, fixed.

A related issue is that, if the final fchdir/chdir fails, no indication of the
problem is passed to back to the caller.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/15539] nftw with FTW_CHDIR doesn't restore cwd upon cancellation

[neleai at seznam dot cz]

https://sourceware.org/bugzilla/show_bug.cgi?id=15539

Ondrej Bilka <neleai at seznam dot cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |neleai at seznam dot cz
            Summary|nftw with FTW_HDIR doesn't  |nftw with FTW_CHDIR doesn't
                   |restore cwd upon            |restore cwd upon
                   |cancellation                |cancellation
           Severity|normal                      |enhancement

--- Comment #1 from Ondrej Bilka <neleai at seznam dot cz> ---
Changing directories in multithread environment is asking for trouble, If you
want this fixed write a patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.