public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "aoliva at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/15539] New: nftw with FTW_HDIR doesn't restore cwd upon cancellation
Date: Sun, 26 May 2013 16:43:00 -0000	[thread overview]
Message-ID: <bug-15539-131@http.sourceware.org/bugzilla/> (raw)

http://sourceware.org/bugzilla/show_bug.cgi?id=15539

            Bug ID: 15539
           Summary: nftw with FTW_HDIR doesn't restore cwd upon
                    cancellation
           Product: glibc
           Version: 2.18
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: aoliva at sourceware dot org
                CC: drepper.fsp at gmail dot com

Various resources can be leaked by ftw because it has no cleanup handler to
release allocated memory in case of thread cancellation.  Leaking memory and
file descriptors is unfortunate, but not always a show-stopper, but changing
the current working directory and not restoring it at the end feels a bit more
serious to me.  I'm not sure nftw is ever called with FTW_CHDIR in
multi-threaded programs, but I thought I'd report this issue so that it can be
discussed and, if found relevant, fixed.

A related issue is that, if the final fchdir/chdir fails, no indication of the
problem is passed to back to the caller.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


             reply	other threads:[~2013-05-26 16:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-26 16:43 aoliva at sourceware dot org [this message]
2013-10-20 17:27 ` [Bug libc/15539] nftw with FTW_CHDIR " neleai at seznam dot cz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-15539-131@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).