public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "carlos at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/15661] posix_fallocate fallback code buggy and dangerous
Date: Wed, 03 Jun 2015 04:26:00 -0000	[thread overview]
Message-ID: <bug-15661-131-EKThL0g7Uz@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-15661-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=15661

--- Comment #9 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to Rich Felker from comment #8)
> I think the XSH 2.9.7 justification is something of a cop-out, and the
> behavior is still undesirable/QoI-issue, but at least it's arguably
> conforming to the extent that applications should avoid depending on
> stricter behavior.

I agree with you, but I'm torn. There are definately applications that rely on
the fallback to work, and if we remove the fallback we'll have a ton of
applications doing the allocation loop themselves, likely getting the overflow
checking wrong, and the blocksize computation wrong. Therefore in the interest
of public safety it seems best to simply leave the loop in place.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


  parent reply	other threads:[~2015-06-03  4:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-21  0:10 [Bug libc/15661] New: " bugdal at aerifal dot cx
2013-06-21  0:59 ` [Bug libc/15661] " bugdal at aerifal dot cx
2013-06-24 16:43 ` zlynx at acm dot org
2014-06-13 15:02 ` fweimer at redhat dot com
2014-06-14  3:49 ` bugdal at aerifal dot cx
2015-04-24  8:00 ` Jean-Baptiste.Leonesio@esi-group.com
2015-04-24  8:01 ` Jean-Baptiste.Leonesio@esi-group.com
2015-04-24 11:42 ` fweimer at redhat dot com
2015-04-24 11:57 ` fweimer at redhat dot com
2015-06-03  3:49 ` carlos at redhat dot com
2015-06-03  4:23 ` bugdal at aerifal dot cx
2015-06-03  4:26 ` carlos at redhat dot com [this message]
2015-06-05  9:20 ` fweimer at redhat dot com
2015-06-05 13:16 ` fweimer at redhat dot com
2015-06-05 16:52 ` zlynx at acm dot org
2015-06-05 18:02 ` carlos at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-15661-131-EKThL0g7Uz@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).