public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug soft-fp/15667] New: __FP_FRAC_ADD_3 shadowing variables in _FP_MUL_MEAT_2_wide_3mul
@ 2013-06-22 11:41 jsm28 at gcc dot gnu.org
  2013-06-22 19:28 ` [Bug soft-fp/15667] " jsm28 at gcc dot gnu.org
  2014-06-13 17:30 ` fweimer at redhat dot com
  0 siblings, 2 replies; 3+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2013-06-22 11:41 UTC (permalink / raw)
  To: glibc-bugs

http://sourceware.org/bugzilla/show_bug.cgi?id=15667

            Bug ID: 15667
           Summary: __FP_FRAC_ADD_3 shadowing variables in
                    _FP_MUL_MEAT_2_wide_3mul
           Product: glibc
           Version: 2.17
            Status: NEW
          Severity: normal
          Priority: P2
         Component: soft-fp
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
                CC: joseph at codesourcery dot com

The soft-fp macro __FP_FRAC_ADD_3 defines variables _c1 and _c2.  The macro
_FP_MUL_MEAT_2_wide_3mul defines its own variables with those names and calls
__FP_FRAC_ADD_3 with arguments involving them, yielding erroneous results when
the wrong variables get used.

(I don't think this actually affects the current uses of soft-fp in glibc on
any architecture; it came up while testing a patch adding new uses.  But it
seems appropriate to file this in Bugzilla anyway.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug soft-fp/15667] __FP_FRAC_ADD_3 shadowing variables in _FP_MUL_MEAT_2_wide_3mul
  2013-06-22 11:41 [Bug soft-fp/15667] New: __FP_FRAC_ADD_3 shadowing variables in _FP_MUL_MEAT_2_wide_3mul jsm28 at gcc dot gnu.org
@ 2013-06-22 19:28 ` jsm28 at gcc dot gnu.org
  2014-06-13 17:30 ` fweimer at redhat dot com
  1 sibling, 0 replies; 3+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2013-06-22 19:28 UTC (permalink / raw)
  To: glibc-bugs

http://sourceware.org/bugzilla/show_bug.cgi?id=15667

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.18 by:

commit 695c378f81263640618bdebf56eaa065f578251f
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Sat Jun 22 19:27:41 2013 +0000

    Fix soft-fp shadowing between __FP_FRAC_ADD_3 and _FP_MUL_MEAT_2_wide_3mul
(bug 15667).

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug soft-fp/15667] __FP_FRAC_ADD_3 shadowing variables in _FP_MUL_MEAT_2_wide_3mul
  2013-06-22 11:41 [Bug soft-fp/15667] New: __FP_FRAC_ADD_3 shadowing variables in _FP_MUL_MEAT_2_wide_3mul jsm28 at gcc dot gnu.org
  2013-06-22 19:28 ` [Bug soft-fp/15667] " jsm28 at gcc dot gnu.org
@ 2014-06-13 17:30 ` fweimer at redhat dot com
  1 sibling, 0 replies; 3+ messages in thread
From: fweimer at redhat dot com @ 2014-06-13 17:30 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=15667

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-06-13 17:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-22 11:41 [Bug soft-fp/15667] New: __FP_FRAC_ADD_3 shadowing variables in _FP_MUL_MEAT_2_wide_3mul jsm28 at gcc dot gnu.org
2013-06-22 19:28 ` [Bug soft-fp/15667] " jsm28 at gcc dot gnu.org
2014-06-13 17:30 ` fweimer at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).