[Bug build/15711] New: Endless loop building misc/bits/syscall.d in glibc 2.17

[Bug build/15711] New: Endless loop building misc/bits/syscall.d in glibc 2.17

[carlos.velasco at nimastelecom dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15711

            Bug ID: 15711
           Summary: Endless loop building misc/bits/syscall.d in glibc
                    2.17
           Product: glibc
           Version: 2.17
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: carlos.velasco at nimastelecom dot com
                CC: carlos at redhat dot com

When building glibc 2.17 I stepped into an endless loop building
"misc/bits/syscall.d".

===
make[2]: Leaving directory `/compile/glibc-2.17/misc'
make[2]: Entering directory `/compile/glibc-2.17/misc'
/bin/install -c -m 644 ../include/stdc-predef.h /usr/include/stdc-predef.h
{ \
 echo '/* Generated at libc build time from kernel syscall list.  */';\
 echo ''; \
 echo '#ifndef _SYSCALL_H'; \
 echo '# error "Never use <bits/syscall.h> directly; include <sys/syscall.h>
instead."'; \
 echo '#endif'; \
 echo ''; \
  \
 echo ''; \
   gcc -m64 -E -MD -MP -MF /compile/glibc-build/misc/bits/syscall.d-t32 -MT
'/compile/glibc-build/misc/bits/syscall.h
/compile/glibc-build/misc/bits/syscall.d' -x c 
../sysdeps/unix/sysv/linux/sys/syscall.h -D__i386__ -U__x86_64__ -D_LIBC -dM |
sed -n 's@^#define __NR_\([^ ]*\) .*$@#define SYS_\1 __NR_\1@p' | LC_ALL=C sort
> /compile/glibc-build/misc/bits/syscall.h.new32;  echo '#if !defined
__x86_64__'; cat /compile/glibc-build/misc/bits/syscall.h.new32; echo '#endif';
rm -f /compile/glibc-build/misc/bits/syscall.h.new32;   gcc -m64 -E -MD -MP -MF
/compile/glibc-build/misc/bits/syscall.d-t64 -MT
'/compile/glibc-build/misc/bits/syscall.h
/compile/glibc-build/misc/bits/syscall.d' -x c 
../sysdeps/unix/sysv/linux/sys/syscall.h -U__i386__ -D__x86_64__ -U__ILP32__
-D__LP64__ -D_LIBC -dM | sed -n 's@^#define __NR_\([^ ]*\) .*$@#define SYS_\1
__NR_\1@p' | LC_ALL=C sort > /compile/glibc-build/misc/bits/syscall.h.new64; 
echo '#if defined __x86_64__ && defined __LP64__'; cat
/compile/glibc-build/misc/bits/syscall.h.new64; echo '#endif'; rm -f
/compile/glibc-build/misc/bits/syscall.h.new64;   gcc -m64 -E -MD -MP -MF
/compile/glibc-build/misc/bits/syscall.d-tx32 -MT
'/compile/glibc-build/misc/bits/syscall.h
/compile/glibc-build/misc/bits/syscall.d' -x c 
../sysdeps/unix/sysv/linux/sys/syscall.h -U__i386__ -D__x86_64__ -D__ILP32__
-U__LP64__ -D_LIBC -dM | sed -n 's@^#define __NR_\([^ ]*\) .*$@#define SYS_\1
__NR_\1@p' | LC_ALL=C sort > /compile/glibc-build/misc/bits/syscall.h.newx32; 
echo '#if defined __x86_64__ && defined __ILP32__'; cat
/compile/glibc-build/misc/bits/syscall.h.newx32; echo '#endif'; rm -f
/compile/glibc-build/misc/bits/syscall.h.newx32;  \
} > /compile/glibc-build/misc/bits/syscall.h.new
mv -f /compile/glibc-build/misc/bits/syscall.h.new
/compile/glibc-build/misc/bits/syscall.h
sed -e 's@ /compile/glibc-build/@ $(common-objpfx)@g' -e
's@^/compile/glibc-build/@$(common-objpfx)@g' \
 /compile/glibc-build/misc/bits/syscall.d-t32
/compile/glibc-build/misc/bits/syscall.d-t64
/compile/glibc-build/misc/bits/syscall.d-tx32 >
/compile/glibc-build/misc/bits/syscall.d-t3
rm -f /compile/glibc-build/misc/bits/syscall.d-t32
/compile/glibc-build/misc/bits/syscall.d-t64
/compile/glibc-build/misc/bits/syscall.d-tx32
mv -f /compile/glibc-build/misc/bits/syscall.d-t3
/compile/glibc-build/misc/bits/syscall.d
make[2]: Leaving directory `/compile/glibc-2.17/misc'
make[2]: Entering directory `/compile/glibc-2.17/misc'
/bin/install -c -m 644 ../include/stdc-predef.h /usr/include/stdc-predef.h
{ \
 echo '/* Generated at libc build time from kernel syscall list.  */';\
 echo ''; \
 echo '#ifndef _SYSCALL_H'; \
 echo '# error "Never use <bits/syscall.h> directly; include <sys/syscall.h>
instead."'; \
 echo '#endif'; \
 echo ''; \
  \
 echo ''; \
   gcc -m64 -E -MD -MP -MF /compile/glibc-build/misc/bits/syscall.d-t32 -MT
'/compile/glibc-build/misc/bits/syscall.h
/compile/glibc-build/misc/bits/syscall.d' -x c 
../sysdeps/unix/sysv/linux/sys/syscall.h -D__i386__ -U__x86_64__ -D_LIBC -dM |
sed -n 's@^#define __NR_\([^ ]*\) .*$@#define SYS_\1 __NR_\1@p' | LC_ALL=C sort
> /compile/glibc-build/misc/bits/syscall.h.new32;  echo '#if !defined
__x86_64__'; cat /compile/glibc-build/misc/bits/syscall.h.new32; echo '#endif';
rm -f /compile/glibc-build/misc/bits/syscall.h.new32;   gcc -m64 -E -MD -MP -MF
/compile/glibc-build/misc/bits/syscall.d-t64 -MT
'/compile/glibc-build/misc/bits/syscall.h
/compile/glibc-build/misc/bits/syscall.d' -x c 
../sysdeps/unix/sysv/linux/sys/syscall.h -U__i386__ -D__x86_64__ -U__ILP32__
-D__LP64__ -D_LIBC -dM | sed -n 's@^#define __NR_\([^ ]*\) .*$@#define SYS_\1
__NR_\1@p' | LC_ALL=C sort > /compile/glibc-build/misc/bits/syscall.h.new64; 
echo '#if defined __x86_64__ && defined __LP64__'; cat
/compile/glibc-build/misc/bits/syscall.h.new64; echo '#endif'; rm -f
/compile/glibc-build/misc/bits/syscall.h.new64;   gcc -m64 -E -MD -MP -MF
/compile/glibc-build/misc/bits/syscall.d-tx32 -MT
'/compile/glibc-build/misc/bits/syscall.h
/compile/glibc-build/misc/bits/syscall.d' -x c 
../sysdeps/unix/sysv/linux/sys/syscall.h -U__i386__ -D__x86_64__ -D__ILP32__
-U__LP64__ -D_LIBC -dM | sed -n 's@^#define __NR_\([^ ]*\) .*$@#define SYS_\1
__NR_\1@p' | LC_ALL=C sort > /compile/glibc-build/misc/bits/syscall.h.newx32; 
echo '#if defined __x86_64__ && defined __ILP32__'; cat
/compile/glibc-build/misc/bits/syscall.h.newx32; echo '#endif'; rm -f
/compile/glibc-build/misc/bits/syscall.h.newx32;  \
} > /compile/glibc-build/misc/bits/syscall.h.new
mv -f /compile/glibc-build/misc/bits/syscall.h.new
/compile/glibc-build/misc/bits/syscall.h
sed -e 's@ /compile/glibc-build/@ $(common-objpfx)@g' -e
's@^/compile/glibc-build/@$(common-objpfx)@g' \
 /compile/glibc-build/misc/bits/syscall.d-t32
/compile/glibc-build/misc/bits/syscall.d-t64
/compile/glibc-build/misc/bits/syscall.d-tx32 >
/compile/glibc-build/misc/bits/syscall.d-t3
rm -f /compile/glibc-build/misc/bits/syscall.d-t32
/compile/glibc-build/misc/bits/syscall.d-t64
/compile/glibc-build/misc/bits/syscall.d-tx32
mv -f /compile/glibc-build/misc/bits/syscall.d-t3
/compile/glibc-build/misc/bits/syscall.d
make[2]: Leaving directory `/compile/glibc-2.17/misc'
make[2]: Entering directory `/compile/glibc-2.17/misc'
/bin/install -c -m 644 ../include/stdc-predef.h /usr/include/stdc-predef.h
{ \
 echo '/* Generated at libc build time from kernel syscall list.  */';\
 echo ''; \
 echo '#ifndef _SYSCALL_H'; \
 echo '# error "Never use <bits/syscall.h> directly; include <sys/syscall.h>
instead."'; \
 echo '#endif'; \
 echo ''; \
  \
 echo ''; \
   gcc -m64 -E -MD -MP -MF /compile/glibc-build/misc/bits/syscall.d-t32 -MT
'/compile/glibc-build/misc/bits/syscall.h
/compile/glibc-build/misc/bits/syscall.d' -x c 
../sysdeps/unix/sysv/linux/sys/syscall.h -D__i386__ -U__x86_64__ -D_LIBC -dM |
sed -n 's@^#define __NR_\([^ ]*\) .*$@#define SYS_\1 __NR_\1@p' | LC_ALL=C sort
> /compile/glibc-build/misc/bits/syscall.h.new32;  echo '#if !defined
__x86_64__'; cat /compile/glibc-build/misc/bits/syscall.h.new32; echo '#endif';
rm -f /compile/glibc-build/misc/bits/syscall.h.new32;   gcc -m64 -E -MD -MP -MF
/compile/glibc-build/misc/bits/syscall.d-t64 -MT
'/compile/glibc-build/misc/bits/syscall.h
/compile/glibc-build/misc/bits/syscall.d' -x c 
../sysdeps/unix/sysv/linux/sys/syscall.h -U__i386__ -D__x86_64__ -U__ILP32__
-D__LP64__ -D_LIBC -dM | sed -n 's@^#define __NR_\([^ ]*\) .*$@#define SYS_\1
__NR_\1@p' | LC_ALL=C sort > /compile/glibc-build/misc/bits/syscall.h.new64; 
echo '#if defined __x86_64__ && defined __LP64__'; cat
/compile/glibc-build/misc/bits/syscall.h.new64; echo '#endif'; rm -f
/compile/glibc-build/misc/bits/syscall.h.new64;   gcc -m64 -E -MD -MP -MF
/compile/glibc-build/misc/bits/syscall.d-tx32 -MT
'/compile/glibc-build/misc/bits/syscall.h
/compile/glibc-build/misc/bits/syscall.d' -x c 
../sysdeps/unix/sysv/linux/sys/syscall.h -U__i386__ -D__x86_64__ -D__ILP32__
-U__LP64__ -D_LIBC -dM | sed -n 's@^#define __NR_\([^ ]*\) .*$@#define SYS_\1
__NR_\1@p' | LC_ALL=C sort > /compile/glibc-build/misc/bits/syscall.h.newx32; 
echo '#if defined __x86_64__ && defined __ILP32__'; cat
/compile/glibc-build/misc/bits/syscall.h.newx32; echo '#endif'; rm -f
/compile/glibc-build/misc/bits/syscall.h.newx32;  \
} > /compile/glibc-build/misc/bits/syscall.h.new
mv -f /compile/glibc-build/misc/bits/syscall.h.new
/compile/glibc-build/misc/bits/syscall.h
sed -e 's@ /compile/glibc-build/@ $(common-objpfx)@g' -e
's@^/compile/glibc-build/@$(common-objpfx)@g' \
 /compile/glibc-build/misc/bits/syscall.d-t32
/compile/glibc-build/misc/bits/syscall.d-t64
/compile/glibc-build/misc/bits/syscall.d-tx32 >
/compile/glibc-build/misc/bits/syscall.d-t3
rm -f /compile/glibc-build/misc/bits/syscall.d-t32
/compile/glibc-build/misc/bits/syscall.d-t64
/compile/glibc-build/misc/bits/syscall.d-tx32
mv -f /compile/glibc-build/misc/bits/syscall.d-t3
/compile/glibc-build/misc/bits/syscall.d
make[2]: Leaving directory `/compile/glibc-2.17/misc'
===

Debugging (make -d) shows that loop is caused by a prerequisite:
Prerequisite `/usr/include/stdc-predef.h' is newer than target
`/compile/glibc-build/misc/bits/syscall.d'

The problem is that this header is installed just before making this target:
Invoking recipe from ../Makerules:1072 to update target
`/usr/include/stdc-predef.h'.
/bin/install -c -m 644 ../include/stdc-predef.h /usr/include/stdc-predef.h

So this creates an endless loop.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/15711] Endless loop building misc/bits/syscall.d in glibc 2.17

[joseph at codesourcery dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15711

--- Comment #1 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
Probably the compilations used in generating syscall.h should use 
-ffreestanding to avoid implicit stdc-predef.h inclusion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/15711] Endless loop building misc/bits/syscall.d in glibc 2.17

[carlos at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15711

--- Comment #2 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to joseph@codesourcery.com from comment #1)
> Probably the compilations used in generating syscall.h should use 
> -ffreestanding to avoid implicit stdc-predef.h inclusion.

I'm also seeing this on some systems. Looking into a solution.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/15711] Endless loop building misc/bits/syscall.d in glibc 2.17

[bnelson at nelsonbe dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15711

re_nelson <bnelson at nelsonbe dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bnelson at nelsonbe dot com

--- Comment #3 from re_nelson <bnelson at nelsonbe dot com> ---
(In reply to Carlos O'Donell from comment #2)

> (In reply to joseph@codesourcery.com from comment #1)
> > Probably the compilations used in generating syscall.h should use 
> > -ffreestanding to avoid implicit stdc-predef.h inclusion.
> 
> I'm also seeing this on some systems. Looking into a solution.

Here's my quick fix hack to deal with the timestamp problem cited in the first
comment:


*** /tmp/Makerules      2013-07-08 05:57:52.325353460 -0500
--- ./glibc-2.17/Makerules     2013-07-08 05:54:39.367878616 -0500
***************
*** 795,800 ****
--- 795,801 ----
  define do-install
  $(make-target-directory)
  $(INSTALL_DATA) $< $@
+ touch -d '0.5 seconds ago' $@
  endef

  # Make the target directory if it doesn't exist, using the `mkinstalldirs'

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/15711] Endless loop building misc/bits/syscall.d in glibc 2.17

[carlos at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15711

--- Comment #4 from Carlos O'Donell <carlos at redhat dot com> ---
The patch that worked for me was:
http://sourceware.org/ml/libc-alpha/2013-07/msg00161.html

However this is a band-aid fix. We need to figure out why the compiler isn't
seeing include/stdc-predef.h first (as Andreas points out).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/15711] Endless loop building misc/bits/syscall.d in glibc 2.17

[joseph at codesourcery dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15711

--- Comment #5 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
I don't see any -I options at all in the make output quoted in this bug - 
in particular, none that would cause source tree headers to be used.  (The 
makefile rules use $(sysincludes), presumably so that the kernel headers 
can be found if --with-headers is used to locate them.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/15711] Endless loop building misc/bits/syscall.d in glibc 2.17

[carlos at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15711

--- Comment #6 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to joseph@codesourcery.com from comment #5)
> I don't see any -I options at all in the make output quoted in this bug - 
> in particular, none that would cause source tree headers to be used.  (The 
> makefile rules use $(sysincludes), presumably so that the kernel headers 
> can be found if --with-headers is used to locate them.)

Thanks, that's a good point I hadn't noticed yet.

In fact the search paths are only:
 /usr/lib/gcc/x86_64-redhat-linux/4.7.2/include
 /home/carlos/install-linux/include

Which is the system headers and the linux headers used for the build.

Given that this header doesn't need include/stdc-predef.h the best solution is
to use -ffreestanding instead of including more include directories from the
source tree.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/15711] Endless loop building misc/bits/syscall.d in glibc 2.17

[carlos at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15711

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Carlos O'Donell <carlos at redhat dot com> ---
commit d7e06450b9d730d7b62ba52f611585810fa902df
Author: Carlos O'Donell <carlos@redhat.com>
Date:   Tue Jul 16 17:55:43 2013 -0400

    BZ #15711: Avoid circular dependency for syscall.h

    The generated header is compiled with `-ffreestanding' to avoid any
    circular dependencies against the installed implementation headers.
    Such a dependency would require the implementation header to be
    installed before the generated header could be built (See bug 15711).
    In current practice the generated header dependencies do not include
    any of the implementation headers removed by the use of `-ffreestanding'.

    ---

    2013-07-15  Carlos O'Donell  <carlos@redhat.com>

        [BZ #15711]
        * sysdeps/unix/sysv/linux/Makefile ($(objpfx)bits/syscall%h):
        Avoid system header dependency with -ffreestanding.
        ($(objpfx)bits/syscall%d): Likewise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/15711] Endless loop building misc/bits/syscall.d in glibc 2.17

[carlos at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15711

--- Comment #8 from Carlos O'Donell <carlos at redhat dot com> ---
I do not plan to backport this to 2.17. If you need this fix in 2.17 please
open another bug to request a backport of the fix.

This bug only happens if you have permission to install stdc-predef.h to your
target prefix, which may or may not require root.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/15711] Endless loop building misc/bits/syscall.d in glibc 2.17

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15711

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.