From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <glibc-bugs-return-19189-listarch-glibc-bugs=sources.redhat.com@sourceware.org>
Received: (qmail 17303 invoked by alias); 21 Jul 2013 10:41:01 -0000
Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <glibc-bugs.sourceware.org>
List-Subscribe: <mailto:glibc-bugs-subscribe@sourceware.org>
List-Post: <mailto:glibc-bugs@sourceware.org>
List-Help: <mailto:glibc-bugs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: glibc-bugs-owner@sourceware.org
Received: (qmail 15033 invoked by uid 48); 21 Jul 2013 10:38:55 -0000
From: "siddhesh at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug ports/15759] tile: C++11 destructors aren't working right
Date: Sun, 21 Jul 2013 10:41:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: ports
X-Bugzilla-Version: 2.18
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: siddhesh at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-15759-131-Ml4KrHggEP@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-15759-131@http.sourceware.org/bugzilla/>
References: <bug-15759-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-07/txt/msg00130.txt.bz2

http://sourceware.org/bugzilla/show_bug.cgi?id=15759

Siddhesh Poyarekar <siddhesh at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |siddhesh at redhat dot com

--- Comment #1 from Siddhesh Poyarekar <siddhesh at redhat dot com> ---
Looks like a bug in _dl_unmap.  It returns without unmapping the object if the
program is not running in a simulator:

/* Support notifying the simulator about removed objects prior to munmap().  */
void internal_function
_dl_unmap (struct link_map *l)
{
  int shift;

  /* Don't bother if not in the simulator.  */
  if (__insn_mfspr (SPR_SIM_CONTROL) == 0)
    return;

...

  __munmap ((void *) l->l_map_start, l->l_map_end - l->l_map_start);
}


Looks like the right code should be:


/* Support notifying the simulator about removed objects prior to munmap().  */
void internal_function
_dl_unmap (struct link_map *l)
{
  int shift;

  /* Don't bother if not in the simulator.  */
  if (__insn_mfspr (SPR_SIM_CONTROL) == 0)
    goto out;

...

out:
  __munmap ((void *) l->l_map_start, l->l_map_end - l->l_map_start);
}

-- 
You are receiving this mail because:
You are on the CC list for the bug.