public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "corbellini.andrea at gmail dot com" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug libc/15763] shm_open/unlink let you write outside SHMDIR Date: Sat, 20 Jul 2013 20:40:00 -0000 [thread overview] Message-ID: <bug-15763-131-DPBSmkSb8x@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-15763-131@http.sourceware.org/bugzilla/> http://sourceware.org/bugzilla/show_bug.cgi?id=15763 --- Comment #4 from Andrea Corbellini <corbellini.andrea at gmail dot com> --- I agree with you about EISDIR being a bad error number. I raised the problem of directories because I do have a directory in my /dev/shm. It's a directory created by Byobu (http://byobu.co/) used as cache. Byobu is written in Bash, so it's not affected by the behavior of shm_open(). However it shows that the possibility of encountering directories in /dev/shm is not remote and also shows that such directories aren't created maliciously (although we might say Byobu is buggy). Whether it makes sense to create directories in /dev/shm or not, I still think that shm_open() with O_RDONLY should not open them: otherwise every call to read() will fail with EISDIR (which, as you noted, is not a good error number). If we allow shm_open() to return directories, then we are returning broken file descriptors. About fstat: you might use it just for O_RDONLY. I think this is a feasible approach as people expect some delay when accessing resources. Also, fstat should not be noticeably slow. -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2013-07-20 20:40 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-20 10:55 [Bug libc/15763] New: " corbellini.andrea at gmail dot com 2013-07-20 17:04 ` [Bug libc/15763] " bugdal at aerifal dot cx 2013-07-20 18:45 ` corbellini.andrea at gmail dot com 2013-07-20 19:09 ` bugdal at aerifal dot cx 2013-07-20 20:40 ` corbellini.andrea at gmail dot com [this message] 2013-10-31 13:03 ` neleai at seznam dot cz 2014-06-13 13:21 ` fweimer at redhat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-15763-131-DPBSmkSb8x@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).