public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "corbellini.andrea at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/15763] shm_open/unlink let you write outside SHMDIR
Date: Sat, 20 Jul 2013 18:45:00 -0000	[thread overview]
Message-ID: <bug-15763-131-cu4xsLeKOR@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-15763-131@http.sourceware.org/bugzilla/>

http://sourceware.org/bugzilla/show_bug.cgi?id=15763

--- Comment #2 from Andrea Corbellini <corbellini.andrea at gmail dot com> ---
There should be a third constraint: no directories. Consider:

  shm_open (".", O_RDONLY, 0666);

It contains no slashes, it's lower than NAME_MAX but is still an invalid name.
errno should be EINVAL in this case.

Also consider this code:

  mkdir ("/dev/shm/some-name", 0666);
  shm_open ("some-name", O_RDONLY, 0666);

Currently it works. If you specify O_WRONLY and O_RDWR you get EINVAL from
open(2).
In my opinion, errno should be EISDIR in any case (O_RDONLY, O_WRONLY and
O_RDWR).

-- 
You are receiving this mail because:
You are on the CC list for the bug.


  parent reply	other threads:[~2013-07-20 18:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-20 10:55 [Bug libc/15763] New: " corbellini.andrea at gmail dot com
2013-07-20 17:04 ` [Bug libc/15763] " bugdal at aerifal dot cx
2013-07-20 18:45 ` corbellini.andrea at gmail dot com [this message]
2013-07-20 19:09 ` bugdal at aerifal dot cx
2013-07-20 20:40 ` corbellini.andrea at gmail dot com
2013-10-31 13:03 ` neleai at seznam dot cz
2014-06-13 13:21 ` fweimer at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-15763-131-cu4xsLeKOR@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).