public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "guilliam.xavier at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/15799] glibc div() code is broken
Date: Wed, 31 Jul 2013 09:13:00 -0000	[thread overview]
Message-ID: <bug-15799-131-cSdx2tglwc@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-15799-131@http.sourceware.org/bugzilla/>

http://sourceware.org/bugzilla/show_bug.cgi?id=15799

--- Comment #1 from Guilliam Xavier <guilliam.xavier at gmail dot com> ---
* I must make a small correction:

  assert(abs(q * D) <= abs(N));

is correct, but the following is actually not strictly equivalent:

  assert((r < 0) == (N < 0));  // sign(r) == sign(N)

because we can have N == -10, D == 5 and q == -2, r == 0 (the quotient is
exact), so I think a corrected equivalent would be rather:

  assert(r == 0 || (r < 0) == (N < 0));

(And just after that: typo: "discard" -> "discarded".)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


  reply	other threads:[~2013-07-31  9:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-29 18:53 [Bug libc/15799] New: " guilliam.xavier at gmail dot com
2013-07-31  9:13 ` guilliam.xavier at gmail dot com [this message]
2013-08-01  7:43 ` [Bug libc/15799] " guilliam.xavier at gmail dot com
2013-10-30 15:09 ` cvs-commit at gcc dot gnu.org
2014-06-13  9:45 ` fweimer at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-15799-131-cSdx2tglwc@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).