From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18477 invoked by alias); 19 Aug 2013 18:29:37 -0000 Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: glibc-bugs-owner@sourceware.org Received: (qmail 18432 invoked by uid 48); 19 Aug 2013 18:29:35 -0000 From: "carlos at redhat dot com" To: glibc-bugs@sourceware.org Subject: [Bug localedata/15831] Bad $expect passed from tst-fmon.sh to tst-fmon Date: Mon, 19 Aug 2013 18:29:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: localedata X-Bugzilla-Version: 2.17 X-Bugzilla-Keywords: glibc_2.17 X-Bugzilla-Severity: normal X-Bugzilla-Who: carlos at redhat dot com X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2013-08/txt/msg00089.txt.bz2 http://sourceware.org/bugzilla/show_bug.cgi?id=15831 --- Comment #5 from Carlos O'Donell --- (In reply to joseph@codesourcery.com from comment #4) > On Wed, 14 Aug 2013, carlos at redhat dot com wrote: > > > There are patches outstanding to glibc to allow it to build with a POSIX shell > > and not require bash-specific extensions. > > > > I suggest looking through back months in libc-alpha, finding the patches that > > were posted and adding them to the `Pending Reviews' list so we don't loose > > track of them and get around to reviewing them: > > http://sourceware.org/glibc/wiki/Pending%20Reviews > > > > Note, you need to be in EditorGroup to edit the wiki: > > http://sourceware.org/glibc/wiki/EditorGroup > > > > This would go a long way to fixing this problem. > > > > At present we only support /bin/bash, thus closing as RESOLVED/INVALID. > > I don't believe your answer justifies closing this bug, or is in any way > relevant to this bug. Such patches as there are are about making > installed bash scripts such as ldd into installed POSIX shell scripts. > They are not about supporting building or testing glibc without bash > available for scripts that require bash. And they are not about cases > where scripts use /bin/sh but in fact require non-POSIX shell features - > such cases are all bugs, for which two fixes are possible in each case > (either explicitly require bash for the script, or make it work with the > POSIX shell). If that's the case then I've misremembered the patches that have been posted. > This script (tst-fmon.sh) is an sh script. So, if it doesn't work with a > POSIX shell, that's a bug, not an enhancement request, and not invalid, > and should be fixed in one of those two ways. Good point. > Now, the analysis in this bug does not appear to disclose whether in fact > the script is doing anything non-POSIX, or whether the problem comes from > a dash bug where dash fails to follow POSIX requirements - if the latter, > the bug would indeed be invalid. But such an analysis of whether the > differences between bash and dash reflect a dash bug or the script > requiring something beyond POSIX is needed before the bug can be > considered invalid. I have completed a review of tst-fmon.sh and I see nothing that is non-POSIX in the shell. I've looked for common bash-isms (function, case, numeric loops, expand sequences, extended glob, select, ==) and fond none. I also ran Debian's checkbashisms perl script and it found no bash-isms in the script. Therefore I'm leaving it closed as resolved/invalid and leaving it up to the submitter to work out the dash bug. -- You are receiving this mail because: You are on the CC list for the bug.