[Bug math/16068] [i386/x86_64] x86 and x86_64 fesetenv exclude state they should include

[Bug math/16068] [i386/x86_64] x86 and x86_64 fesetenv exclude state they should include

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16068

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|x86 and x86_64 fesetenv     |[i386/x86_64] x86 and
                   |exclude state they should   |x86_64 fesetenv exclude
                   |include                     |state they should include

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16068] [i386/x86_64] x86 and x86_64 fesetenv exclude state they should include

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16068

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  77d08acaadfb197cd03c56ac8f72baabeb305f25 (commit)
      from  28162f4dac274a4b635d95fc2442bef888df1d57 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=77d08acaadfb197cd03c56ac8f72baabeb305f25

commit 77d08acaadfb197cd03c56ac8f72baabeb305f25
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Fri May 9 16:59:56 2014 +0000

    Include SSE state in i386 fenv_t (bug 16064).

    This patch fixes bug 16064, i386 fenv_t not including SSE state, using
    the technique suggested there of storing the state in the existing
    __eip field of fenv_t to avoid needing to increase the size of fenv_t
    and add new symbol versions.  The included testcase, which previously
    failed for i386 (but passed for x86_64), illustrates how the previous
    state was buggy.

    This patch causes the SSE state to be included *to the extent it is on
    x86_64*.  Where some state should logically be included but isn't for
    x86_64 (see bug 16068), this patch does not cause it to be included
    for i386 either.  The idea is that any patch fixing that bug should
    fix it for both x86_64 and i386 at once.

    Tested i386 and x86_64.  (I haven't tested the case of a CPU without
    SSE2 disabling the test.)

        [BZ #16064]
        * sysdeps/i386/fpu/fegetenv.c: Include <unistd.h>, <ldsodefs.h>
        and <dl-procinfo.h>.
        (__fegetenv): Save SSE state in envp->__eip if supported.
        * sysdeps/i386/fpu/feholdexcpt.c (feholdexcept): Save SSE state in
        envp->__eip if supported.
        * sysdeps/i386/fpu/fesetenv.c: Include <unistd.h>, <ldsodefs.h>
        and <dl-procinfo.h>.
        (__fesetenv): Always set __eip, __cs_selector, __opcode,
        __data_offset and __data_selector in environment to 0.  Set SSE
        state if supported.
        * sysdeps/x86/fpu/Makefile [$(subdir) = math] (tests): Add
        test-fenv-sse.
        [$(subdir) = math] (CFLAGS-test-fenv-sse.c): Add -msse2
        -mfpmath=sse.
        * sysdeps/x86/fpu/test-fenv-sse.c: New file.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                       |   19 +++++
 NEWS                            |    4 +-
 sysdeps/i386/fpu/fegetenv.c     |    6 ++
 sysdeps/i386/fpu/feholdexcpt.c  |    4 +-
 sysdeps/i386/fpu/fesetenv.c     |   50 ++++++++++----
 sysdeps/x86/fpu/Makefile        |    2 +
 sysdeps/x86/fpu/test-fenv-sse.c |  138 +++++++++++++++++++++++++++++++++++++++
 7 files changed, 204 insertions(+), 19 deletions(-)
 create mode 100644 sysdeps/x86/fpu/test-fenv-sse.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16068] [i386/x86_64] x86 and x86_64 fesetenv exclude state they should include

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16068

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16068] [i386/x86_64] x86 and x86_64 fesetenv exclude state they should include

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16068

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  0b9af583a5c2d68085e88cece13952bf05dc4882 (commit)
      from  eae6c382bdca2e7ac582a69d56c9c228b678ee67 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=0b9af583a5c2d68085e88cece13952bf05dc4882

commit 0b9af583a5c2d68085e88cece13952bf05dc4882
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Oct 28 18:50:20 2015 +0000

    Fix i386/x86_64 fesetenv SSE exception clearing (bug 19181).

    The i386 and x86_64 versions of fesetenv, when called with FE_DFL_ENV
    or FE_NOMASK_ENV as argument, do not clear SSE exceptions raised in
    MXCSR.  These arguments should, like other fenv_t values, represent
    the whole of the floating-point state, so such exceptions should be
    cleared; this patch adds the required clearing.  (Discovered while
    working on bug 16068.)

    Tested for x86_64 and x86.

        [BZ #19181]
        * sysdeps/i386/fpu/fesetenv.c (__fesetenv): Clear already-raised
        SSE exceptions when argument is FE_DFL_ENV or FE_NOMASK_ENV.
        * sysdeps/x86_64/fpu/fesetenv.c (__fesetenv): Likewise.
        * math/test-fenv-clear-main.c: New file.
        * math/test-fenv-clear.c: Likewise.
        * math/Makefile (tests): Add test-fenv-clear.
        * sysdeps/x86/fpu/test-fenv-clear-sse.c: New file.
        * sysdeps/x86/fpu/Makefile [$(subdir) = math] (tests): Add
        test-fenv-clear-sse.
        [$(subdir) = math] (CFLAGS-test-fenv-clear-sse.c): New variable.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                             |   12 ++++
 NEWS                                  |    2 +-
 math/Makefile                         |    2 +-
 math/test-fenv-clear-main.c           |   91 +++++++++++++++++++++++++++++++++
 math/test-fenv-clear.c                |    2 +
 sysdeps/i386/fpu/fesetenv.c           |    4 ++
 sysdeps/x86/fpu/Makefile              |    3 +-
 sysdeps/x86/fpu/test-fenv-clear-sse.c |   45 ++++++++++++++++
 sysdeps/x86_64/fpu/fesetenv.c         |    4 ++
 9 files changed, 162 insertions(+), 3 deletions(-)
 create mode 100644 math/test-fenv-clear-main.c
 create mode 100644 math/test-fenv-clear.c
 create mode 100644 sysdeps/x86/fpu/test-fenv-clear-sse.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16068] [i386/x86_64] x86 and x86_64 fesetenv exclude state they should include

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16068

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.23

--- Comment #4 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.23.

-- 
You are receiving this mail because:
You are on the CC list for the bug.