[Bug math/16171] New: drem should be alias of remainder

[Bug math/16171] New: drem should be alias of remainder

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16171

            Bug ID: 16171
           Summary: drem should be alias of remainder
           Product: glibc
           Version: 2.18
            Status: NEW
          Severity: normal
          Priority: P2
         Component: math
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org

The libm drem function just calls __remainder.  It should instead be an alias
at the ELF level (for all the remainder implementations for all floating-point
types; mostly this is a matter of updating w_remainder* files, but watch out
for sysdeps/ieee754/ldbl-opt/nldbl-remainder.c and the IA64 libm).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16171] drem should be alias of remainder

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16171

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16171] drem should be alias of remainder

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16171

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16171] drem should be alias of remainder

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16171

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.23

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.23.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16171] drem should be alias of remainder

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16171

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  5ce8f125063cfd8660710a80243cb705e66f0626 (commit)
      from  91bcb95ad4454ea878e7a2eac5c4a0eeb6fb4de6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5ce8f125063cfd8660710a80243cb705e66f0626

commit 5ce8f125063cfd8660710a80243cb705e66f0626
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Thu Oct 29 22:29:21 2015 +0000

    Make drem an alias of remainder (bug 16171).

    The libm drem functions just call the corresponding __remainder
    functions.  This patch removes the unnecessary wrappers by making them
    into weak aliases at the ELF level.

    Tested for x86_64, x86, mips64 and powerpc.

        [BZ #16171]
        * math/w_remainder.c (drem): Define as weak alias of __remainder.
        [NO_LONG_DOUBLE] (dreml): Define as weak alias of __remainder.
        * math/w_remainderf.c (dremf): Define as weak alias of
        __remainderf.
        * math/w_remainderl.c (dreml): Define as weak alias of
        __remainderl.
        * sysdeps/ia64/fpu/e_remainder.S (drem): Define as weak alias of
        __remainder.
        * sysdeps/ia64/fpu/e_remainderf.S (dremf): Define as weak alias of
        __remainderf.
        * sysdeps/ia64/fpu/e_remainderl.S (dreml): Define as weak alias of
        __remainderl.
        * sysdeps/ieee754/ldbl-opt/nldbl-remainder.c (dreml): Define as
        weak alias of remainderl.
        * sysdeps/ieee754/ldbl-opt/w_remainder.c
        [LONG_DOUBLE_COMPAT(libm, GLIBC_2_0)] (__drem): Define as strong
        alias of __remainder.
        [LONG_DOUBLE_COMPAT(libm, GLIBC_2_0)] (dreml): Use compat_symbol.
        * sysdeps/ieee754/ldbl-opt/w_remainderl.c (__dreml): Define as
        strong alias of __remainderl.
        (dreml): Use long_double_symbol.
        * math/Makefile (libm-calls): Remove w_drem.
        * sysdeps/ieee754/ldbl-opt/Makefile (libnldbl-calls): Remove drem.
        (CFLAGS-nldbl-drem.c): Remove variable.
        (CFLAGS-nldbl-remainder.c): Add -fno-builtin-dreml.
        * math/w_drem.c: Remove file.
        * math/w_dremf.c: Likewise.
        * math/w_dreml.c: Likewise.
        * sysdeps/ieee754/ldbl-opt/nldbl-drem.c: Likewise.
        * sysdeps/ieee754/ldbl-opt/w_drem.c: Likewise.
        * sysdeps/ieee754/ldbl-opt/w_dreml.c: Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                  |   33 ++++++++++++++++++++++++++++
 NEWS                                       |   24 ++++++++++----------
 math/Makefile                              |    2 +-
 math/w_drem.c                              |   19 ----------------
 math/w_dremf.c                             |   16 -------------
 math/w_dreml.c                             |   17 --------------
 math/w_remainder.c                         |    2 +
 math/w_remainderf.c                        |    1 +
 math/w_remainderl.c                        |    1 +
 sysdeps/ia64/fpu/e_remainder.S             |    1 +
 sysdeps/ia64/fpu/e_remainderf.S            |    1 +
 sysdeps/ia64/fpu/e_remainderl.S            |    1 +
 sysdeps/ieee754/ldbl-opt/Makefile          |    5 +--
 sysdeps/ieee754/ldbl-opt/nldbl-drem.c      |    8 ------
 sysdeps/ieee754/ldbl-opt/nldbl-remainder.c |    2 +
 sysdeps/ieee754/ldbl-opt/w_drem.c          |    5 ----
 sysdeps/ieee754/ldbl-opt/w_dreml.c         |    5 ----
 sysdeps/ieee754/ldbl-opt/w_remainder.c     |    2 +
 sysdeps/ieee754/ldbl-opt/w_remainderl.c    |    2 +
 19 files changed, 61 insertions(+), 86 deletions(-)
 delete mode 100644 math/w_drem.c
 delete mode 100644 math/w_dremf.c
 delete mode 100644 math/w_dreml.c
 delete mode 100644 sysdeps/ieee754/ldbl-opt/nldbl-drem.c
 delete mode 100644 sysdeps/ieee754/ldbl-opt/w_drem.c
 delete mode 100644 sysdeps/ieee754/ldbl-opt/w_dreml.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.