[Bug math/16195] New: Warnings from systemtap probes in libm in non-systemtap configurations

[Bug math/16195] New: Warnings from systemtap probes in libm in non-systemtap configurations

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16195

            Bug ID: 16195
           Summary: Warnings from systemtap probes in libm in
                    non-systemtap configurations
           Product: glibc
           Version: 2.19
            Status: NEW
          Severity: normal
          Priority: P2
         Component: math
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
                CC: siddhesh at redhat dot com

As I noted in https://sourceware.org/ml/libc-alpha/2013-10/msg00502.html
building for a non-systemtap configuration produces warnings building libm of
the form:

../sysdeps/ieee754/dbl-64/e_atan2.c:602:4: warning: the address of 'p' will
always evaluate as 'true' [-Waddress]

The probes need fixing so they don't generate warnings in such a configuration.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16195] Warnings from systemtap probes in libm in non-systemtap configurations

[siddhesh at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16195

Siddhesh Poyarekar <siddhesh at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |siddhesh at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16195] Warnings from systemtap probes in libm in non-systemtap configurations

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=16195

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  520d437b9455560d099fe6bd9664be1f9f76868b (commit)
      from  416e014536950a77183013fa4c86cb42dfd322a9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=520d437b9455560d099fe6bd9664be1f9f76868b

commit 520d437b9455560d099fe6bd9664be1f9f76868b
Author: Siddhesh Poyarekar <siddhesh@redhat.com>
Date:   Tue Dec 3 12:26:12 2013 +0530

    [BZ #16195] Fix build warnings from systemtap probes in non-systemtap
configurations

    Joseph pointed out in the bug report (and in an earlier thread) that
    systemtap probes cause build time warnings like the following:

        ../sysdeps/ieee754/dbl-64/e_atan2.c:602:4: warning: the address of
        'p' will always evaluate as 'true' [-Waddress]

    due to the fact that we're now passing non-weak variables to
    LIBC_PROBE in the libm probes.  This happens only on configurations
    that do not enable systemtap.  The macro definition of LIBC_PROBE in
    this case only acts as a sanity checker to ensure that the number
    parameters passed to LIBC_PROBE is equal to the argument count
    parameter passed before it.  This can be done in a much simpler manner
    by just adding a macro definition for each number of arguments.  I am
    assuming here that we don't really want to bother with supporting
    LIBC_PROBE with an indeterminate number of arguments and if there is a
    need for a probe to have more data than what is currently supported (4
    arguments), one could simply add an additional macro here.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog            |   11 +++++++++++
 NEWS                 |    4 ++--
 include/stap-probe.h |   15 ++++++++-------
 3 files changed, 21 insertions(+), 9 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16195] Warnings from systemtap probes in libm in non-systemtap configurations

[siddhesh at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16195

Siddhesh Poyarekar <siddhesh at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Siddhesh Poyarekar <siddhesh at redhat dot com> ---
Fixed in master.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16195] Warnings from systemtap probes in libm in non-systemtap configurations

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16195

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.