[Bug math/16422] New: math-float, math-double failing llrint tests with "Exception "Inexact" set" on ppc32

[Bug math/16422] New: math-float, math-double failing llrint tests with "Exception "Inexact" set" on ppc32

[brooks at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16422

            Bug ID: 16422
           Summary: math-float, math-double failing llrint tests with
                    "Exception "Inexact" set" on ppc32
           Product: glibc
           Version: 2.19
            Status: NEW
          Severity: normal
          Priority: P2
         Component: math
          Assignee: unassigned at sourceware dot org
          Reporter: brooks at gcc dot gnu.org

This is failing with GLIBC trunk as of 10am PST on 2014-01-09.

Configure with "../glibc/configure --prefix=/usr CC='gcc -m32' CXX='g++ -m32'
--target=powerpc32-unknown-linux-gnu --build=powerpc32-unknown-linux-gnu
--host=powerpc32-unknown-linux-gnu" on an IBM Power7; run "make" and "make
check".

I'm seeing failures in both math/test-float and math/test-double, with
essentially identical test-*.out outputs.  The contents of test-float.out are:

This bug report is fr the llrint failures; I'll file the logb_downward failure
separately.

----
testing float (without inline functions)
Failure: Test: logb_downward (1.000e+0)
Result:
 is:         -0.00000000000000000000e+00  -0x0.00000000000000000000p+0
 should be:   0.00000000000000000000e+00   0x0.00000000000000000000p+0
 difference:  0.00000000000000000000e+00   0x0.00000000000000000000p+0
 ulp       :  0.0000
 max.ulp   :  0.0000
Failure: llrint (2097151.0): Exception "Inexact" set
Failure: llrint (8388608.0): Exception "Inexact" set
Failure: llrint (16777216.0): Exception "Inexact" set
Failure: llrint (4503601774854144.0): Exception "Inexact" set
Failure: llrint_tonearest (2097151.0): Exception "Inexact" set
Failure: llrint_tonearest (8388608.0): Exception "Inexact" set
Failure: llrint_tonearest (16777216.0): Exception "Inexact" set
Failure: llrint_tonearest (4503601774854144.0): Exception "Inexact" set
Failure: llrint_towardzero (2097151.0): Exception "Inexact" set
Failure: llrint_towardzero (8388608.0): Exception "Inexact" set
Failure: llrint_towardzero (16777216.0): Exception "Inexact" set
Failure: llrint_towardzero (4503601774854144.0): Exception "Inexact" set
Failure: llrint_downward (2097151.0): Exception "Inexact" set
Failure: llrint_downward (8388608.0): Exception "Inexact" set
Failure: llrint_downward (16777216.0): Exception "Inexact" set
Failure: llrint_downward (4503601774854144.0): Exception "Inexact" set
Failure: llrint_upward (2097151.0): Exception "Inexact" set
Failure: llrint_upward (8388608.0): Exception "Inexact" set
Failure: llrint_upward (16777216.0): Exception "Inexact" set
Failure: llrint_upward (4503601774854144.0): Exception "Inexact" set
Failure: nexttoward (qNaN, 1.1): Exception "Inexact" set

Test suite completed:
  10843 test cases plus 10244 tests for exception flags and
    10244 tests for errno executed.
  22 errors occurred.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16422] math-float, math-double failing llrint tests with "Exception "Inexact" set" on ppc32

[brooks at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16422

--- Comment #1 from Brooks Moses <brooks at gcc dot gnu.org> ---
FWIW, this is also failing in math-ldouble.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16422] math-float, math-double failing llrint tests with "Exception "Inexact" set" on ppc32

[brooks at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16422

Brooks Moses <brooks at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.19

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16422] math-float, math-double failing llrint tests with "Exception "Inexact" set" on ppc32

[joseph at codesourcery dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=16422

--- Comment #2 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
On Thu, 9 Jan 2014, brooks at gcc dot gnu.org wrote:

> This bug report is fr the llrint failures; I'll file the logb_downward failure
> separately.

I strongly suspect these are GCC bug 59412 rather than a glibc bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16422] math-float, math-double failing llrint tests with "Exception "Inexact" set" on ppc32

[azanella at linux dot vnet.ibm.com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16422

Adhemerval Zanella Netto <azanella at linux dot vnet.ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |azanella at linux dot vnet.ibm.com

--- Comment #3 from Adhemerval Zanella Netto <azanella at linux dot vnet.ibm.com> ---
I'm not seeing these in my environment with GCC 4.6, 4.7, and 4.8. I also
suspect some of these may be related to other issues:

There are different issues on this bug report:

1. The logb_downward has been fixed in GCC 4.6, GCC 4.7 and forward. Check if
you GCC build contains the fixes described at
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52775

2. nexttoward is also a known issue that has been fixed upstream:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57363

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16422] math-float, math-double failing llrint tests with "Exception "Inexact" set" on ppc32

[joseph at codesourcery dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=16422

--- Comment #4 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
On Fri, 10 Jan 2014, azanella at linux dot vnet.ibm.com wrote:

> 1. The logb_downward has been fixed in GCC 4.6, GCC 4.7 and forward. Check if
> you GCC build contains the fixes described at
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52775

That's only a fix for processors with that instruction.  The general GCC 
bug (with -frounding-math) remains for older processors.

The llrint issue likely also depends on the processor for which GCC is 
configured; likely processors with TARGET_FCFID are unaffected.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16422] [powerpc] math-float, math-double failing llrint tests with "Exception "Inexact" set" on ppc32

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16422

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Host|                            |powerpc*-*-*
            Summary|math-float, math-double     |[powerpc] math-float,
                   |failing llrint tests with   |math-double failing llrint
                   |"Exception "Inexact" set"   |tests with "Exception
                   |on ppc32                    |"Inexact" set" on ppc32

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16422] [powerpc] math-float, math-double failing llrint tests with "Exception "Inexact" set" on ppc32

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16422

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16422] [powerpc] math-float, math-double failing llrint tests with "Exception "Inexact" set" on ppc32

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16422

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  e8dab9477f33ab7a67405f4e147cbaa1a4bb443b (commit)
      from  5b1766a0cde255eff9868a9eeb49f66a89842cb8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=e8dab9477f33ab7a67405f4e147cbaa1a4bb443b

commit e8dab9477f33ab7a67405f4e147cbaa1a4bb443b
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Tue Oct 13 00:52:54 2015 +0000

    Fix powerpc32 llrint, llrintf bad exceptions (bug 16422).

    The versions of llrint and llrintf for older powerpc32 processors
    convert the results of __rint / __rintf to long long int, resulting in
    spurious exceptions from such casts in certain cases.  This patch
    makes glibc work around the problems with the libgcc conversions when
    the compiler used to build glibc doesn't use the fctidz instruction
    for them.

    Tested for powerpc.

        [BZ #16422]
        * sysdeps/powerpc/powerpc32/fpu/configure.ac (libc_cv_ppc_fctidz):
        New configure test.
        * sysdeps/powerpc/powerpc32/fpu/configure: Regenerated.
        * config.h.in [_LIBC] (HAVE_PPC_FCTIDZ): New macro.
        * sysdeps/powerpc/powerpc32/fpu/s_llrint.c: Include <limits.h>,
        <math_private.h> and <stdint.h>.
        (__llrint): Avoid conversions to long long int where those might
        raise spurious exceptions.
        * sysdeps/powerpc/powerpc32/fpu/s_llrintf.c: Include
        <math_private.h> and <stdint.h>.
        (__llrintf): Avoid conversions to long long int where those might
        raise spurious exceptions.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                  |   16 ++++++++++++++
 NEWS                                       |   20 +++++++++---------
 config.h.in                                |    3 ++
 sysdeps/powerpc/powerpc32/fpu/configure    |   27 ++++++++++++++++++++++++
 sysdeps/powerpc/powerpc32/fpu/configure.ac |   16 ++++++++++++++
 sysdeps/powerpc/powerpc32/fpu/s_llrint.c   |   31 +++++++++++++++++++++++++++-
 sysdeps/powerpc/powerpc32/fpu/s_llrintf.c  |   22 +++++++++++++++++++-
 7 files changed, 123 insertions(+), 12 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/16422] [powerpc] math-float, math-double failing llrint tests with "Exception "Inexact" set" on ppc32

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=16422

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|2.19                        |2.23

--- Comment #6 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.23.

-- 
You are receiving this mail because:
You are on the CC list for the bug.