public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug network/16529] New: netinet/in.h breaks -pedantic
@ 2014-02-04 23:54 alvarezp at alvarezp dot ods.org
2014-02-05 22:46 ` [Bug network/16529] " bugdal at aerifal dot cx
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: alvarezp at alvarezp dot ods.org @ 2014-02-04 23:54 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=16529
Bug ID: 16529
Summary: netinet/in.h breaks -pedantic
Product: glibc
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: network
Assignee: unassigned at sourceware dot org
Reporter: alvarezp at alvarezp dot ods.org
Created attachment 7393
--> https://sourceware.org/bugzilla/attachment.cgi?id=7393&action=edit
Fix: comma at end of enum broke -pedantic
netinet/in.h breaks -pedantic
$ gcc -Wall -Wextra -Werror -pedantic -pedantic-errors -D_POSIX_C_SOURCE -o in
in-standard.c
In file included from in-standard.c:1:0:
/home/user/src/glibc/inet/netinet/in.h:111:21: error: comma at end of
enumerator list [-pedantic]
Line 111 was introduced by commit 6c82a2f8 [1] so there's not much history
about it. Simply the comma needs to be removed.
[1] https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=6c82a2f8
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug network/16529] netinet/in.h breaks -pedantic 2014-02-04 23:54 [Bug network/16529] New: netinet/in.h breaks -pedantic alvarezp at alvarezp dot ods.org @ 2014-02-05 22:46 ` bugdal at aerifal dot cx 2014-02-05 23:12 ` joseph at codesourcery dot com ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: bugdal at aerifal dot cx @ 2014-02-05 22:46 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=16529 Rich Felker <bugdal at aerifal dot cx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugdal at aerifal dot cx --- Comment #1 from Rich Felker <bugdal at aerifal dot cx> --- Isn't GCC supposed to ignore such issues in system headers? I don't think glibc has an obligation to satisfy the GCC developers' style guidelines, unless this is actually an issue of the current code being invalid C. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug network/16529] netinet/in.h breaks -pedantic 2014-02-04 23:54 [Bug network/16529] New: netinet/in.h breaks -pedantic alvarezp at alvarezp dot ods.org 2014-02-05 22:46 ` [Bug network/16529] " bugdal at aerifal dot cx @ 2014-02-05 23:12 ` joseph at codesourcery dot com 2014-02-06 1:41 ` alvarezp at alvarezp dot ods.org ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: joseph at codesourcery dot com @ 2014-02-05 23:12 UTC (permalink / raw) To: glibc-bugs http://sourceware.org/bugzilla/show_bug.cgi?id=16529 --- Comment #2 from joseph at codesourcery dot com <joseph at codesourcery dot com> --- Headers are generally meant to be (C90 + long long) if possible, without requiring other C99 features such as trailing commas in enums. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug network/16529] netinet/in.h breaks -pedantic 2014-02-04 23:54 [Bug network/16529] New: netinet/in.h breaks -pedantic alvarezp at alvarezp dot ods.org 2014-02-05 22:46 ` [Bug network/16529] " bugdal at aerifal dot cx 2014-02-05 23:12 ` joseph at codesourcery dot com @ 2014-02-06 1:41 ` alvarezp at alvarezp dot ods.org 2014-02-06 16:20 ` carlos at redhat dot com 2014-06-13 8:41 ` fweimer at redhat dot com 4 siblings, 0 replies; 6+ messages in thread From: alvarezp at alvarezp dot ods.org @ 2014-02-06 1:41 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=16529 --- Comment #3 from Octavio Alvarez <alvarezp at alvarezp dot ods.org> --- It is invalid C before C99. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug network/16529] netinet/in.h breaks -pedantic 2014-02-04 23:54 [Bug network/16529] New: netinet/in.h breaks -pedantic alvarezp at alvarezp dot ods.org ` (2 preceding siblings ...) 2014-02-06 1:41 ` alvarezp at alvarezp dot ods.org @ 2014-02-06 16:20 ` carlos at redhat dot com 2014-06-13 8:41 ` fweimer at redhat dot com 4 siblings, 0 replies; 6+ messages in thread From: carlos at redhat dot com @ 2014-02-06 16:20 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=16529 Carlos O'Donell <carlos at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from Carlos O'Donell <carlos at redhat dot com> --- Fixed for master and thus fixed for 2.19. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug network/16529] netinet/in.h breaks -pedantic 2014-02-04 23:54 [Bug network/16529] New: netinet/in.h breaks -pedantic alvarezp at alvarezp dot ods.org ` (3 preceding siblings ...) 2014-02-06 16:20 ` carlos at redhat dot com @ 2014-06-13 8:41 ` fweimer at redhat dot com 4 siblings, 0 replies; 6+ messages in thread From: fweimer at redhat dot com @ 2014-06-13 8:41 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=16529 Florian Weimer <fweimer at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |security- -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-13 8:41 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-02-04 23:54 [Bug network/16529] New: netinet/in.h breaks -pedantic alvarezp at alvarezp dot ods.org 2014-02-05 22:46 ` [Bug network/16529] " bugdal at aerifal dot cx 2014-02-05 23:12 ` joseph at codesourcery dot com 2014-02-06 1:41 ` alvarezp at alvarezp dot ods.org 2014-02-06 16:20 ` carlos at redhat dot com 2014-06-13 8:41 ` fweimer at redhat dot com
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).